From owner-svn-src-head@freebsd.org Wed Jun 14 16:13:00 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B062EB95E20; Wed, 14 Jun 2017 16:13:00 +0000 (UTC) (envelope-from alc@rice.edu) Received: from pp2.rice.edu (proofpoint2.mail.rice.edu [128.42.201.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E1A06E938; Wed, 14 Jun 2017 16:12:59 +0000 (UTC) (envelope-from alc@rice.edu) Received: from pps.filterd (pp2.rice.edu [127.0.0.1]) by pp2.rice.edu (8.16.0.17/8.16.0.17) with SMTP id v5EAoPW2010020; Wed, 14 Jun 2017 11:12:56 -0500 Received: from mh2.mail.rice.edu (mh2.mail.rice.edu [128.42.201.21]) by pp2.rice.edu with ESMTP id 2b0btj9nqj-1; Wed, 14 Jun 2017 11:12:56 -0500 X-Virus-Scanned: by amavis-2.7.0 at mh2.mail.rice.edu, auth channel Received: from 108-254-203-201.lightspeed.hstntx.sbcglobal.net (108-254-203-201.lightspeed.hstntx.sbcglobal.net [108.254.203.201]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) (Authenticated sender: alc) by mh2.mail.rice.edu (Postfix) with ESMTPSA id CCF6A500150; Wed, 14 Jun 2017 11:12:55 -0500 (CDT) Subject: Re: svn commit: r319905 - in head/sys: kern sys To: rgrimes@freebsd.org Cc: Hans Petter Selasky , Alan Cox , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201706141552.v5EFq5rJ062076@pdx.rh.CN85.dnsmgr.net> From: Alan Cox Message-ID: <06a51008-6cb1-fbc1-500b-c5821b306649@rice.edu> Date: Wed, 14 Jun 2017 11:12:55 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <201706141552.v5EFq5rJ062076@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=5 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611190142 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2017 16:13:00 -0000 On 06/14/2017 10:52, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On 06/14/2017 06:04, Hans Petter Selasky wrote: >>> On 06/13/17 19:49, Alan Cox wrote: >>>> +#define bitcount64(x) __bitcount64((uint64_t)(x)) >>> bitcount64() is already defined by sys/libkern.h - use that?=20 >> This snippet appears in code that is only used when compiling this fil= e >> as a user-space application for testing. Attempting to use >> sys/libkern.h in the user-space compilation provoked warnings. > Could we please add a comment to this define indicating this? > This snippet is enclosed in the #else of an #ifdef _KERNEL, where the entire #ifdef _KERNEL is not that long, so if you're looking at the actual file rather than a diff, it's pretty clear. And just a few lines above the #ifdef _KERNEL is the comment: * = =20 * This code can be compiled stand-alone for debugging. =20 */