From nobody Tue Apr 28 14:12:29 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4j7b2NYlz6bXcF for ; Tue, 28 Apr 2026 14:12:43 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4j7b0Cybz3CT8 for ; Tue, 28 Apr 2026 14:12:42 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488ff90d6c7so98687725e9.2 for ; Tue, 28 Apr 2026 07:12:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777385561; x=1777990361; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kg7W09kD9ed6JiT8aRuUNtU2I9c8GldU/Z6vRNKA2MA=; b=MAF3Nku33OeDzm0vw/NmAial6yqgzG+AufcqoFFOi7xrzmP1iP4BdRpETlaq05nHOH qbNvp0J4q1BLOofikhlyKDj2WWsuJYljT2NAmJkvnHcKDjchbHwy7Gt9hPaTUjnhmaZ0 5m9i+32NyU5ncWN+atjLfwAu0ifQK6rOR+1rtn7Nqa5gSL+WxPso9NcSYfqeBUZR4MVl OhFIF4p7apUSaYuQkOm0M1C9/I8ULGue22UW680jHKYz+Ru9jGG15+W/h91VI5DwSRcs UYHSfad4oOVLjO2q5oOxvO+K0cJ2ZvukXm1yzFJCdGgptkTktAnnIZrH+H2Wb2eHXllC bxTw== X-Forwarded-Encrypted: i=1; AFNElJ97DNMqCRzh99VBPojkATLD79JURnNLx48Uzf28+XUN8v0P7TTXp5EI+q4Of2sp3oSr7IvxBIxFaVT7A/hfGRpFkBkwqw==@freebsd.org X-Gm-Message-State: AOJu0Yxk3r1BeVtYygj7ILLhgWfodbpzrfN18X4lo7FVmx9NcOOi430M CMQ6F2VxT4+3VkDtpeZYrAdf0/v+myNlzY/dyVQXob7E+dyafg6Oym3QyNYCR0kNAo8= X-Gm-Gg: AeBDies2oXbreze4DQT/aYNVBz39TLgX7IV5z5D76bfiOsHKTLSyMDTMWTRJOQqisAe 7yMVbpu0O2sEm30lmUTQ1abqS0hbpJvVs3vaLRsmfKs3zclQPOfJyBG+MqNiCL1dUr9ZUIRi3lG OFPa1eO4bliCuvUldLpjfVRbX/D4IxyCdJ8FyxI8PZKtqbDcLEMgtI4C84B1CyLXZ99/Y/3KXGy hsV/JVYnhrVWtcm3UzLx7lPZRxP9thWTx5Crex4GDqe8YPRpOYnRypHQZ3LG/0BU3bVp8CmSWST ykwTNuGpeVCSEJikNFG81UsfDC9rSieg6kQ80oZ90M+MIQgOK5EeWy79Pu52lDjhtgS3wWcnkM+ fOVtjnKtBnaDq+8+sfogiOnOjYGZaev1yGg3bmiOIPIpDGBxAlYOWavLkJ7qrD8LJn4WOTNHSNV maNrNWRoslP1RXpNN/6lrdsrLO9lDoPJnDLEZZPM1I9l3/eAtoYkMVMB39LOjalAwDGc7CBA0uL b8L5Y8ryLwfvJ6/ X-Received: by 2002:a05:600c:c491:b0:485:3f30:6250 with SMTP id 5b1f17b1804b1-48a77b1b7ffmr50644655e9.20.1777385561200; Tue, 28 Apr 2026 07:12:41 -0700 (PDT) Received: from smtpclient.apple (nat-184-78.net.cam.ac.uk. [131.111.184.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a774a48bbsm20153395e9.12.2026.04.28.07.12.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Apr 2026 07:12:40 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: f2f831b2c151 - main - bnxt_en: Add core SR-IOV infrastructure From: Jessica Clarke In-Reply-To: <69f0576a.31521.3b0166c9@gitrepo.freebsd.org> Date: Tue, 28 Apr 2026 15:12:29 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Chandrakanth Patil Content-Transfer-Encoding: quoted-printable Message-Id: <9C0E560F-C521-420D-AA07-1D2959AE0A5A@freebsd.org> References: <69f0576a.31521.3b0166c9@gitrepo.freebsd.org> To: Sumit Saxena X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g4j7b0Cybz3CT8 X-Spamd-Bar: ---- On 28 Apr 2026, at 07:44, Sumit Saxena wrote: >=20 > The branch main has been updated by ssaxena: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df2f831b2c151a9d989a94fc7c894118c= 802ef348 >=20 > commit f2f831b2c151a9d989a94fc7c894118c802ef348 > Author: Chandrakanth Patil > AuthorDate: 2026-03-31 16:59:00 +0000 > Commit: Sumit Saxena > CommitDate: 2026-04-28 06:16:16 +0000 >=20 > bnxt_en: Add core SR-IOV infrastructure >=20 > Introduce the foundational building blocks for SR-IOV Virtual = Function > support on Broadcom NetXtreme-C/E adapters. >=20 > * Add bnxt_sriov.h: defines the extended bnxt_vf_info structure = (per-VF > firmware FID, MAC addresses, VLAN, flags, DMA command buffers, = resource > counts), the bnxt_resc_map helper, flag macros (BNXT_VF_TRUST, > BNXT_VF_SPOOFCHK, etc.), and prototypes for all SR-IOV functions. >=20 > * Add bnxt_sriov.c: implements the SR-IOV attachment sequence > (bnxt_sriov_attach), the iflib IOV callbacks (bnxt_iov_init, > bnxt_iov_uninit, bnxt_iov_vf_add), VF resource allocation and > firmware configuration helpers (bnxt_alloc_vf_resources, > bnxt_cfg_hw_sriov, bnxt_hwrm_func_vf_resc_cfg, = bnxt_hwrm_func_buf_rgtr, > bnxt_hwrm_func_vf_resource_free), and the per-VF parameter = helper. >=20 > * Extend bnxt.h: include bnxt_sriov.h; extend bnxt_pf_info with VF- > tracking fields (vf array, firmware FID/MAC, resource-reservation > strategy, DMA page management, sysctl context); replace the = upstream > bnxt_vf_info stub with the full definition from bnxt_sriov.h; = extend > bnxt_func_qcfg with allocation counters required by the VF = resource > configuration path; add vf_resc_cfg_input and sriov_lock to = bnxt_softc. >=20 > * Update Makefile to build bnxt_sriov.c and include bnxt_sriov.h. >=20 > * Wire up PCI-IOV device methods (pci_iov_init / pci_iov_uninit / > pci_iov_add_vf) and iflib IOV callbacks (ifdi_iov_init / = ifdi_iov_uninit > / ifdi_iov_vf_add) in if_bnxt.c; call bnxt_sriov_attach() from > bnxt_attach_post() on P5+ Physical Functions. >=20 > MFC after: 1 month > Reviewed by: ssaxena > Differential Revision: https://reviews.freebsd.org/D56197 There are a bunch of style violations in this (and not even self-consistent). tools/build/checkstyle9.pl is far from perfect but even it can find a load of issues here. % git show f2f831b2c151a9d989a94fc7c894118c802ef348 | = tools/build/checkstyle9.pl - ... total: 25 errors, 22 warnings, 732 lines checked Jessica