From owner-p4-projects@FreeBSD.ORG  Tue Jan 15 02:11:16 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 74F0816A421; Tue, 15 Jan 2008 02:11:16 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A74016A419
	for <perforce@FreeBSD.org>; Tue, 15 Jan 2008 02:11:16 +0000 (UTC)
	(envelope-from swise@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 21E9A13C4E1
	for <perforce@FreeBSD.org>; Tue, 15 Jan 2008 02:11:16 +0000 (UTC)
	(envelope-from swise@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m0F2BG4Q011776
	for <perforce@FreeBSD.org>; Tue, 15 Jan 2008 02:11:16 GMT
	(envelope-from swise@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m0F2BGxS011728
	for perforce@freebsd.org; Tue, 15 Jan 2008 02:11:16 GMT
	(envelope-from swise@FreeBSD.org)
Date: Tue, 15 Jan 2008 02:11:16 GMT
Message-Id: <200801150211.m0F2BGxS011728@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	swise@FreeBSD.org using -f
From: Steve Wise <swise@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 133299 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jan 2008 02:11:16 -0000

http://perforce.freebsd.org/chv.cgi?CH=133299

Change 133299 by swise@swise:vic10:iwarp on 2008/01/15 02:10:25

	YAGF - Yet Another Genpool Fix!
	
	wasn't rounding up the chunks correctly.

Affected files ...

.. //depot/projects/iwarp/sys/dev/cxgb/ulp/iw_cxgb/iw_cxgb_cxio_hal.h#8 edit

Differences ...

==== //depot/projects/iwarp/sys/dev/cxgb/ulp/iw_cxgb/iw_cxgb_cxio_hal.h#8 (text+ko) ====

@@ -249,7 +249,7 @@
 	int chunks;
 	daddr_t blkno; 
 
-	chunks = size >> gp->gen_chunk_shift;
+	chunks = (size + (1<<gp->gen_chunk_shift) - 1) >> gp->gen_chunk_shift;
 	blkno = blist_alloc(gp->gen_list, chunks);
 
 	if (blkno == SWAPBLK_NONE)
@@ -258,29 +258,13 @@
 	return (gp->gen_base + ((1 << gp->gen_chunk_shift) * blkno));
 }
 
-#define cxio_wait(ctx, lockp, cond) \
-({ \
-	int __ret = 0; \
-	mtx_lock_spin(lockp); \
-	while (!cond) { \
-                msleep_spin(ctx, lockp, "cxio_wait", hz); \
-                if (SIGPENDING(curthread)) { \
-			__ret = ERESTART; \
-                        break; \
-                } \
-	} \
-	mtx_unlock_spin(lockp); \
-	__ret; \
-}) 
-
-
 static __inline void
 gen_pool_free(struct gen_pool *gp, daddr_t address, int size)
 {
 	int chunks;
 	daddr_t blkno;
 	
-	chunks = size >> gp->gen_chunk_shift;
+	chunks = (size + (1<<gp->gen_chunk_shift) - 1) >> gp->gen_chunk_shift;
 	blkno = (address - gp->gen_base) / (1 << gp->gen_chunk_shift);
 	blist_free(gp->gen_list, blkno, chunks);
 }
@@ -292,4 +276,19 @@
 	free(gp, M_DEVBUF);
 }
 
+#define cxio_wait(ctx, lockp, cond) \
+({ \
+	int __ret = 0; \
+	mtx_lock_spin(lockp); \
+	while (!cond) { \
+                msleep_spin(ctx, lockp, "cxio_wait", hz); \
+                if (SIGPENDING(curthread)) { \
+			__ret = ERESTART; \
+                        break; \
+                } \
+	} \
+	mtx_unlock_spin(lockp); \
+	__ret; \
+}) 
+
 #endif