From owner-svn-src-all@FreeBSD.ORG  Tue Jun 15 21:19:46 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19ADB106564A;
	Tue, 15 Jun 2010 21:19:46 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id DF2898FC08;
	Tue, 15 Jun 2010 21:19:45 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 8E4D746C32;
	Tue, 15 Jun 2010 17:19:45 -0400 (EDT)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id D13578A03C;
	Tue, 15 Jun 2010 17:19:44 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Jack F Vogel <jfv@freebsd.org>
Date: Tue, 15 Jun 2010 17:19:39 -0400
User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; )
References: <201006152111.o5FLBpPa095035@svn.freebsd.org>
In-Reply-To: <201006152111.o5FLBpPa095035@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201006151719.39275.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Tue, 15 Jun 2010 17:19:44 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r209218 - head/sys/dev/e1000
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jun 2010 21:19:46 -0000

On Tuesday 15 June 2010 5:11:51 pm Jack F Vogel wrote:
> Author: jfv
> Date: Tue Jun 15 21:11:51 2010
> New Revision: 209218
> URL: http://svn.freebsd.org/changeset/base/209218
> 
> Log:
>   Change to have legacy interrupts use the same
>   handler had a flaw, thanks to John Baldwin for
>   finding it. Change which queue legacy tasks are
>   enqueued on.
>   
>   MFC: soonest

Thanks.

> Modified: head/sys/dev/e1000/if_igb.h
> 
==============================================================================
> --- head/sys/dev/e1000/if_igb.h	Tue Jun 15 21:00:53 2010	(r209217)
> +++ head/sys/dev/e1000/if_igb.h	Tue Jun 15 21:11:51 2010	(r209218)
> @@ -382,7 +382,6 @@ struct adapter {
>  	int		min_frame_size;
>  	struct mtx	core_mtx;
>  	int		igb_insert_vlan_header;
> -	struct task     rxtx_task;
>  	struct taskqueue *tq;	/* adapter task queue */
>          u16		num_queues;

I think the 'tq' pointer here is unused now and can be dropped.

-- 
John Baldwin