From owner-freebsd-testing@FreeBSD.ORG Fri Apr 4 19:05:56 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 688EEF28 for ; Fri, 4 Apr 2014 19:05:56 +0000 (UTC) Received: from mail-qa0-f41.google.com (mail-qa0-f41.google.com [209.85.216.41]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22F235EC for ; Fri, 4 Apr 2014 19:05:55 +0000 (UTC) Received: by mail-qa0-f41.google.com with SMTP id j5so3532209qaq.14 for ; Fri, 04 Apr 2014 12:05:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=OwK1xI/l3P8III7uqimBiMYYuoSKwupmT7Kww47IZfg=; b=Wo/LNVzsuUSavrn5c/jSzUKulrXRewbMFYbuwwl+cPOjLd89iGxd+qApDHGHjFuCFr Rvx2zcKpyOz1QuLOrjq5elKD8oBO7x9cZgNgHDywYcAQK1SjcKR/w/FrRxd0qxpFjO0a v984kw1gr1KG9Uc35XIyoXLS4h4f5CBg+GOQEghLhaOkP8S8/qqoyi6RKqdKmLyb4/k3 OPJg8O9P6r08zWBofXMWNjLoL2tmRGWU18NEPO8WWC8z6Hyskufu0yvvu7f+mmE9Yc9p UJ+06z/XvlW1E/D3KIew1gjz9sOTvUyD5QjsPHwDs/3yKUbJ1xUjZoRfEttXQiaqZq8T z85A== X-Gm-Message-State: ALoCoQkWexrGjscYSxQdFx9K4YFUtSt6Bav5rubkebAEvJCPWhK6dnKztn7e6Zs5CE8KfQpAyF0m X-Received: by 10.224.114.209 with SMTP id f17mr16587221qaq.40.1396638349432; Fri, 04 Apr 2014 12:05:49 -0700 (PDT) Received: from mastodon.meroh.net (cpe-184-153-117-174.rochester.res.rr.com. [184.153.117.174]) by mx.google.com with ESMTPSA id f3sm17887011qag.7.2014.04.04.12.05.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Apr 2014 12:05:48 -0700 (PDT) Sender: Julio Merino Date: Fri, 4 Apr 2014 15:05:43 -0400 From: Julio Merino To: Garrett Cooper Subject: Re: ATF work Message-ID: <20140404190543.GA652@mastodon.meroh.net> References: <20140402085349.GA61802@x2.osted.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "freebsd-testing@freebsd.org" , Peter Holm X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2014 19:05:56 -0000 Just a couple of minor comments: On Wed, Apr 02, 2014 at 11:07:04AM -0700, Garrett Cooper wrote: > (Just to fill in some context on some of the items here) > > On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers wrote: > > lib/libc/tests/net/Makefile has one tested comment out with the > > comment "test uses rump". Would it be possible instead to leave the > > test in the build, but put "require.progs rump_server" in the relevant > > test cases' heads? > > Probably carryover from NetBSD that should be pushed back to NetBSD. Why? rump is "standard" in NetBSD so that's probably not going to fly. It'd be like saying "require.progs = ls". I'd not keep commented code in the tree. There is no point: by the time FreeBSD gets rump (if ever, but it'd take a really long time regardless), the borrowed code may have significantly changed from upstream. And if rump is never imported, this code will remain commented out forever. > > lib/libc/tests/gen/posix_spawn/Makefile contains commented out code. > > Probably incompatibilities between FreeBSD and NetBSD. Then, like above, remove the code... unless the tests should work in FreeBSD but don't yet, in which case marking them as "expected failures" and accompanying them with a PR would be better. Cheers