Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Apr 2012 12:16:14 +1000
From:      Peter Jeremy <peterjeremy@acm.org>
To:        Andrew Thompson <thompsa@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r234403 - head/sys/net
Message-ID:  <20120418021614.GA37269@server.vk2pj.dyndns.org>
In-Reply-To: <201204180139.q3I1dEPZ008424@svn.freebsd.org>
References:  <201204180139.q3I1dEPZ008424@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--xHFwDpU9dbj6ez1V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2012-Apr-18 01:39:14 +0000, Andrew Thompson <thompsa@FreeBSD.org> wrote:
>Log:
>  Remove KASSERTS, they do not add any value here since the pointer is abo=
ut to
>  be derefernced anyway.

Could you give a bit more background to this commit.  You get a crash in
both cases but the KASSERT() at least tells you which variable was NULL
without needing to trawl through the crashdump to find what caused the
NULL pointer dereference trap.

--=20
Peter Jeremy

--xHFwDpU9dbj6ez1V
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk+OI+4ACgkQ/opHv/APuIe/lgCeIrbn2hu/S8ycTqu9d9vRPdnE
vEAAn32jtvIzlauomHYzInuwJbFfyUBB
=sL1q
-----END PGP SIGNATURE-----

--xHFwDpU9dbj6ez1V--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120418021614.GA37269>