From owner-freebsd-arch@freebsd.org Thu Sep 28 18:47:48 2017 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3552DE05FE3 for ; Thu, 28 Sep 2017 18:47:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 017F7698DB for ; Thu, 28 Sep 2017 18:47:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id m103so2387567iod.13 for ; Thu, 28 Sep 2017 11:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PgpAzDHGvsZAYybwBOoKiu4g36sLTSq1BXYQsd2igug=; b=Pqnc3vfaRF1pYtj3SaZBgNLgOuik15QimGu8Q+CEfR7hxU55W55QOvBQSHcZKF+GZz 9waCpoDbPhygIKuF6BlQsYG1+T6v0zb9/mcX6TnZWVLzj3Tyuv8WrGt6uV/6VQb/C7J8 nB8tXuctvEz+5Ry0afSjBfY6YYKES51Q6M2XmS5chf8gKTgP+v78q8O/0Zr0UIBdOfpu yLaYAHHVwbJofJ7Ktkw5Z3aVjByN12z8ngJ1NH+nAXm9U14En/xjbXSgtETKOavdOJFB SbxUJ6PqeLIBa3S6MgSYyTwLA3LFp/V+tOOGU7qTyXB1GrpHTw3P5tplwKoN8x9BjZ4V 3/Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PgpAzDHGvsZAYybwBOoKiu4g36sLTSq1BXYQsd2igug=; b=YYy5jQOXaOZQrA0hjHJLSE2SmBqQBTZ0tQdaE9gY8O5y3tWlr9y8HdSRWlfM3oI0xw Uab5xPJg8KyysRgCCcR5eGaQXheklgV3ZmuJXCCmTvLNskuprJXhi2ZHv+bRaoADL1yw fhb/I+UJti+LRWHwFG9AD4j/5mHhjU3Zy2GTLRrJvEuDstTk0YcusMMwLhaCAHXzDy+N XVldgqtfJBlEXdv683fkyFdcxKTQG668hbhvECCROpGcEUuvyUknm/dqoT/2CMPUri/s LziaUGzbQKivpqpUvHGIDuhptZb5yYOsuuupk35Jf1wRUDVCatpSSD2AaS+15Y5KK2tQ eOUQ== X-Gm-Message-State: AMCzsaXRMI4+FuALdTo5E4dyBRj8kMcN/67ktbddXKKTNRPQKTO/CJbn rCtUzOep2TBQdLndqnAQL+U0MvigurVcMCtNll3iqg== X-Google-Smtp-Source: AOwi7QDj+6CsjbwcMWVnOhiiWu5PhqLaJgRgzs1VO0Oq+aaBt6+cygeXt5ARF0qrNfZJYMztAsda1zrS0MvZ6KvEetE= X-Received: by 10.107.185.7 with SMTP id j7mr9133686iof.221.1506624467206; Thu, 28 Sep 2017 11:47:47 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.2.194 with HTTP; Thu, 28 Sep 2017 11:47:46 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:191c:5e93:2feb:3c70] In-Reply-To: <13426777.FL7aYimd4u@ralph.baldwin.cx> References: <13426777.FL7aYimd4u@ralph.baldwin.cx> From: Warner Losh Date: Thu, 28 Sep 2017 12:47:46 -0600 X-Google-Sender-Auth: KuHafv6Xe2c-ToGzeJhYPKgJ6M8 Message-ID: Subject: Re: lua in zfs To: John Baldwin Cc: "freebsd-arch@freebsd.org" , Andriy Gapon , Ian Lepore Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 18:47:48 -0000 On Thu, Sep 28, 2017 at 11:52 AM, John Baldwin wrote: > On Thursday, September 28, 2017 11:07:35 AM Warner Losh wrote: > > On Thu, Sep 28, 2017 at 10:50 AM, Andriy Gapon wrote: > > > > > On 28/09/2017 19:44, Andriy Gapon wrote: > > > > On 28/09/2017 18:55, Ian Lepore wrote: > > > >> Iirc, the big difference between 5.2.x and 5.3 is that the latter > added > > > >> support for integers. It seems like that would be a good thing, in > the > > > >> kernel. > > > > > > > > I am sure that the ZFS Lua represents numbers as integers and has no > > > floating > > > > point support at all. > > > > > > > > > Some more info: > > > https://github.com/illumos/illumos-gate/blob/master/usr/ > > > src/uts/common/fs/zfs/lua/README.zfs > > > > > > Reading this strongly suggests to me that we're going to have two > versions > > of lua in the tree then: > > > > 1) This version is a modified version of 5.2.4 > > 2) Significant changes have been made to harden this interpreter, which > > won't be in 5.3.0 > > 3) A number of APIs have been removed, which makes it difficult to use > as a > > general purpose thing. > > > > So I think that you should go ahead and import it. The level of work for > my > > request is very high, and significantly diverges us from upstream. It's > > unfortunate that we'll have two versions. But this isn't really pure lua > > but a variant maybe better described as lua-zfs. > > Yes, that was my guess from Andriy's original e-mail. ZFS tends to be a > bit > self-contained and includes its own version of zlib for example. In > general > it seems to use its own version of 3rd party utils rather than sharing > those > with other parts of the system. > Sure. I was vaguely aware of that... But I had to ask to make sure that we couldn't use it, and also provide a 'paper trail' to those grepping the tree / mailing lists for why... Warner