From owner-svn-src-head@freebsd.org Thu Oct 22 13:22:51 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1F96F448A1E; Thu, 22 Oct 2020 13:22:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CH7Mb05dkz3cd8; Thu, 22 Oct 2020 13:22:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D61E518385; Thu, 22 Oct 2020 13:22:50 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f42.google.com with SMTP id t6so808835qvz.4; Thu, 22 Oct 2020 06:22:50 -0700 (PDT) X-Gm-Message-State: AOAM532W777w1WITHkDIiozX7vt++2AfiXfXfjRb2DZgq9kJW4231Uv1 gWULstbt5W1DEhOAkbPc12e+W6Vaq7dDyTo5GnQ= X-Google-Smtp-Source: ABdhPJzIi2RoZyRlYpt9VIIZC7qfkuXXath43UeS166VmN0mmmJHObVj8vx/V+AvO2v++hlG3RDYVov+9VBH8ovBTV0= X-Received: by 2002:a0c:c709:: with SMTP id w9mr2130396qvi.26.1603372970325; Thu, 22 Oct 2020 06:22:50 -0700 (PDT) MIME-Version: 1.0 References: <202010021826.092IQfdj023808@repo.freebsd.org> <44421602932538@mail.yandex.ru> <43251602934532@mail.yandex.ru> <59021602950992@mail.yandex.ru> In-Reply-To: From: Kyle Evans Date: Thu, 22 Oct 2020 08:22:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf To: Warner Losh Cc: "Alexander V. Chernikov" , Hans Petter Selasky , Emmanuel Vadot , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 13:22:51 -0000 On Sat, Oct 17, 2020 at 11:40 AM Warner Losh wrote: > > > > On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov wrote: >> >> 17.10.2020, 14:07, "Hans Petter Selasky" : >> >> On 2020-10-17 14:34, Alexander V. Chernikov wrote: >> >> 17.10.2020, 12:32, "Hans Petter Selasky" : >> >> On 2020-10-17 13:27, Alexander V. Chernikov wrote: >> >> 02.10.2020, 19:26, "Emmanuel Vadot" > >: >> >> Author: manu >> Date: Fri Oct 2 18:26:41 2020 >> New Revision: 366372 >> URL: https://svnweb.freebsd.org/changeset/base/366372 >> >> Log: >> linuxkpi: Add backlight support >> >> Add backlight function to linuxkpi. >> Graphics drivers expose the backlight of the panel directly so >> allow them >> to use the backlight subsystem so >> user can use backlight(8) to configure them. >> >> Reviewed by: hselasky >> Relnotes: yes >> Differential Revision: The FreeBSD Foundation >> >> Added: >> head/sys/compat/linuxkpi/common/include/linux/backlight.h >> (contents, >> props changed) >> Modified: >> head/sys/compat/linuxkpi/common/include/linux/device.h >> head/sys/compat/linuxkpi/common/src/linux_kmod.c >> head/sys/compat/linuxkpi/common/src/linux_pci.c >> head/sys/conf/kmod.mk >> >> It breaks the build for me with >> /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10: >> fatal error: 'backlight_if.h' file not found >> >> >> How do you build? Doesn't break over here. >> >> GENERIC + COMPAT_LINUXKPI. >> >> >> >> Try adding: >> >> options backlight >> >> To the kernel config. >> >> Yep, thank you! >> Maybe it's worth considering adding static assert with the message describing this dependency? > > > Yes. It likely is worth doing something to highlight this issue. > > Warner > I think we just need to slap the two core backlight files with an ` | compat_linux` so that they simply get pulled in if you specify COMPAT_LINUX. config(8) handles this terribly, configng must have a better provides/requires/implies/whatever functionality so we can specify that compat_linux implies backlight and not do crud like this where it becomes more complicated to see what any given option really entails. Thanks, Kyle Evans