Date: Mon, 17 Oct 2016 19:39:39 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: John Marino <freebsd.contact@marino.st> Cc: marino@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files Message-ID: <20161017193939.033c999c@kalimero.tijl.coosemans.org> In-Reply-To: <8cca7750-291e-c7c9-72aa-f91d17373046@marino.st> References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <d8557129-7ede-8ba7-7b8e-8745563930a2@marino.st> <b09dc39e-1656-5f35-cf72-bb4469d350b6@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org> <8cca7750-291e-c7c9-72aa-f91d17373046@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 17 Oct 2016 12:03:44 -0500 John Marino <freebsd.contact@marino.st> =
wrote:
> On 10/17/2016 12:01, Mathieu Arnold wrote:
>> Le 17/10/2016 =C3=A0 18:31, John Marino a =C3=A9crit : =20
>>> On 10/17/2016 11:28, Mathieu Arnold wrote: =20
>>>> Le 17/10/2016 =C3=A0 18:26, John Marino a =C3=A9crit : =20
>>>>> On 10/17/2016 11:20, Mathieu Arnold wrote: =20
>>>>>> Le 17/10/2016 =C3=A0 17:55, John Marino a =C3=A9crit : =20
>>>>>>> On 10/17/2016 10:52, Mathieu Arnold wrote: =20
>>>>>>>> Le 17/10/2016 =C3=A0 17:15, John Marino a =C3=A9crit : =20
>>>>>>>>> Apparently USES=3Dpathfix and USES=3Dautoreconf can't be used
>>>>>>>>> together, so
>>>>>>>>> the pkgconfig directory is now passed via MAKE_ARGS =20
>>>>>>>>
>>>>>>>> That is mostly not true. What usage makes it so that they do not
>>>>>>>> work
>>>>>>>> together ? =20
>>>>>>>
>>>>>>> The results suggest that "${WRKSRC}/configure" was modified, then
>>>>>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that the
>>>>>>> pkgconfig path change was reverted.
>>>>>>>
>>>>>>> That's why I had to replace pathfix with MAKE_ARGS. =20
>>>>>>
>>>>>> No, USES=3Dpathfix changes the content of PATHFIX_MAKEFILEIN, which =
by
>>>>>> default, is Makefile.in. It won't change configure unless you set
>>>>>> PATHFIX_MAKEFILEIN=3Dconfigure.
>>>>>> =20
>>>>>
>>>>> Well, I didn't add MAKE_ARGS for fun.
>>>>> After adding USES+=3Dautoreconf, the build broke. pathfix was still =
in
>>>>> place. You can reproduce by adding pathfix back before "python" and
>>>>> commenting out the new MAKE_ARGS line I added and check with
>>>>> "check-plist" It's easy to confirm. =20
>>>>
>>>> I never said your fix did not work or was not right, I said USES=3Dpat=
hfix
>>>> won't touch configure.
>>>> =20
>>>
>>> Ah, that's the issue. I misspoke. I didn't mean "configure", I mean
>>> the Makefile all along. So you agree in this case pathfix and
>>> autoreconf aren't compatible, right? =20
>>
>> Not at all, if the file patched was Makefile.in, set
>> PATHFIX_MAKEFILEIN=3DMakefile.am and it will work. =20
>=20
> Okay, thanks, I learned something.
> I think the current approach is cleaner anyway though.
Allow me to repeat what I said barely two weeks ago:
Can't we just use lib/pkgconfig already? Having to patch every port
to move it to libdata/pkgconfig is pointless extra work with zero benefit.
Nobody cares that these files are in libdata.
All it takes is this patch and then all pkgconfig hacks can gradually
disappear over time.
--- devel/pkgconf/Makefile (revision 424106)
+++ devel/pkgconf/Makefile (working copy)
@@ -16,7 +16,7 @@ GNU_CONFIGURE=3D yes
INSTALL_TARGET=3D install-strip
USE_LDCONFIG=3D yes
TEST_TARGET=3D check
-CONFIGURE_ARGS=3D --with-pkg-config-dir=3D${PREFIX}/libdata/pkgconf=
ig:/usr/libdata/pkgconfig \
+CONFIGURE_ARGS=3D --with-pkg-config-dir=3D${PREFIX}/lib/pkgconfig:$=
{PREFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \
--with-system-libdir=3D/usr/lib \
--with-system-includedir=3D/usr/include
MAKE_ARGS=3D MANDIR=3D"${MAN1PREFIX}/man/man1"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161017193939.033c999c>