From owner-svn-src-all@FreeBSD.ORG Tue Jan 5 13:12:48 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E6901065692; Tue, 5 Jan 2010 13:12:48 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 23CF58FC0A; Tue, 5 Jan 2010 13:12:48 +0000 (UTC) Received: from compute1.internal (compute1.internal [10.202.2.41]) by gateway1.messagingengine.com (Postfix) with ESMTP id A3D3CC98FC; Tue, 5 Jan 2010 08:12:47 -0500 (EST) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 05 Jan 2010 08:12:47 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=message-id:date:from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpout; bh=ZUMiYOGZdN0uX+/d9wujcvHIs6k=; b=SLhOULiyyM3n+i2Fhv/Lg1MCIzKj51aMm75u0+zFajTofUlJV1ziY2qfNYOirvp5xQPyFSOYGRj3ZqrH1eteihPK7lDVtSO+36M2NsxMyaj3A0k9Yrzr+MQsEMX+WDNW3jwKkFOBxIjLjtBiAU++GT5UE/sEC/ZKdShyx3wUzjI= X-Sasl-enc: 50uKqePfFjUGZgBy7bv0IY+f9PoxDKtC658TR4ca7u4T 1262697167 Received: from [192.168.123.18] (cpc2-dals7-0-0-cust253.hari.cable.virginmedia.com [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id AAAAD4A6B0F; Tue, 5 Jan 2010 08:12:46 -0500 (EST) Message-ID: <4B433ACB.5040902@incunabulum.net> Date: Tue, 05 Jan 2010 13:12:43 +0000 From: Bruce Simpson User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 MIME-Version: 1.0 To: Luigi Rizzo References: <201001041825.o04IPcXb043347@svn.freebsd.org> <20100104190024.GA47532@onelab2.iet.unipi.it> <517EF225-7EEB-4844-A0AD-019AD72F9403@freebsd.org> <20100104222323.GA49068@onelab2.iet.unipi.it> In-Reply-To: <20100104222323.GA49068@onelab2.iet.unipi.it> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Michael Tuexen Subject: Re: moving sctp to a separate directory ? (Re: svn commit: r201523 - head/sys/netinet) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2010 13:12:48 -0000 On 04/01/2010 22:23, Luigi Rizzo wrote: > I also think that the name of the new directory or the exact percentage of > ipv4-ness or netinet-ness of the sctp* and tcp* and multicast* stuff > is irrelevant. Moving directories with svn is so easy that we should not > worry even if we need a couple of attempts to find a good name. > On a related, but different, note: I actually think that the mcast code could have benefitted from C++ style templates. There's a lot of code duplication between the IPv6 and IPv4 versions of those modules. It's the entry points, and argument types, which ultimately mattered, so when integrating the MLD implementation into FreeBSD back last April, I found myself doing 'cp', 'sed', and manual edits mostly to deal with only *slight* semantic differences between IPv4 and IPv6 in the kernel. Having said all that, it seems to me like the netinet/ code overall could do with being split up further into individual files, to make it more manageable. This has sort of already happened as time has gone on. cheers, BMS