From owner-freebsd-current@FreeBSD.ORG  Thu Aug 18 01:51:37 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2FC6B16A420;
	Thu, 18 Aug 2005 01:51:37 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz
	[60.234.149.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0ABA843D48;
	Thu, 18 Aug 2005 01:51:35 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id 4E1931CCD4; Thu, 18 Aug 2005 13:51:34 +1200 (NZST)
Date: Thu, 18 Aug 2005 13:51:34 +1200
From: Andrew Thompson <thompsa@freebsd.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20050818015134.GD97927@heff.fud.org.nz>
Mail-Followup-To: Andrew Thompson <thompsa@freebsd.org>,
	John Baldwin <jhb@FreeBSD.org>, current@FreeBSD.org
References: <200508171511.58378.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200508171511.58378.jhb@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: current@FreeBSD.org
Subject: Re: Locking fixes for xl(4)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Aug 2005 01:51:37 -0000

On Wed, Aug 17, 2005 at 03:11:57PM -0400, John Baldwin wrote:
> The patch below fixes several locking nits including the LOR involving 
> taskqueue_drain()for xl(4).  It does not use taskqueue_stop() (it's #ifdef'd 
> out) as it is not needed for correct operation, just as an optimization.  
> Please test and let me know how it works.  Thanks.
> 

Works for me, and the witness warning on boot has gone.

Name    Mtu Network       Address              Ipkts Ierrs    Opkts Oerrs  Coll
xl0    1500 <Link#3>      00:04:75:d1:f8:98  3522300     0  3034312     0     0


Andrew