From owner-svn-src-head@FreeBSD.ORG  Tue Aug 13 08:49:32 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 02B7BBF8;
 Tue, 13 Aug 2013 08:49:32 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 939A124B2;
 Tue, 13 Aug 2013 08:49:30 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA23389;
 Tue, 13 Aug 2013 11:49:29 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1V9AIC-0001sU-So; Tue, 13 Aug 2013 11:49:28 +0300
Message-ID: <5209F2E0.9000901@FreeBSD.org>
Date: Tue, 13 Aug 2013 11:48:32 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130810 Thunderbird/17.0.8
MIME-Version: 1.0
To: Alexander Motin <mav@FreeBSD.org>
Subject: Re: svn commit: r254275 - head/sys/geom/raid
References: <201308130756.r7D7uf9o086164@svn.freebsd.org>
In-Reply-To: <201308130756.r7D7uf9o086164@svn.freebsd.org>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Aug 2013 08:49:32 -0000

on 13/08/2013 10:56 Alexander Motin said the following:
> +	/* Deny write opens for read-only volumes. */
> +	if (vol->v_read_only && acw > 0) {
> +		error = EROFS;
> +		goto out;
> +	}

I'd like to stir a small (hopefully) discussion (again, hopefully): is EROFS
appropriate here or would ENODEV be better?

EROFS	Read-only filesystem
ENODEV	Operation not supported by device

-- 
Andriy Gapon