Date: Tue, 04 Mar 2014 10:39:30 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Antoine Brodin <antoine@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Adam Weinberger <adamw@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r346968 - head/converters/libiconv Message-ID: <1617323.9tYKgzxRAl@mercury.ph.man.ac.uk> In-Reply-To: <CAALwa8khAJy0-1kozwo42=M6Y%2BmaK9Wdqx5coLMfRb65Jqx%2B2A@mail.gmail.com> References: <201403032115.s23LFU07023939@svn.freebsd.org> <CAALwa8khAJy0-1kozwo42=M6Y%2BmaK9Wdqx5coLMfRb65Jqx%2B2A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 04 Mar 2014 11:35:56 +0100 Antoine Brodin wrote: > On Mon, Mar 3, 2014 at 10:15 PM, Adam Weinberger <adamw@freebsd.org> wrote: > > Author: adamw > > Date: Mon Mar 3 21:15:30 2014 > > New Revision: 346968 > > URL: http://svnweb.freebsd.org/changeset/ports/346968 > > QAT: https://qat.redports.org/buildarchive/r346968/ > > > > Log: > > Don't unconditionally install DOCS. PORTREVISION bump > > for plist change. > > > > PR: ports/186590 > > Approved by: maintainer > > > > Modified: > > head/converters/libiconv/Makefile > > head/converters/libiconv/pkg-plist > > Hi, > > Why didn't you add DOCS to OPTIONS_DEFINE? > This is the policy for ports that respect the DOCS option. Besides, there's no reason for bumping PORTREVISION: plist with default options is the same. Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1617323.9tYKgzxRAl>