From owner-cvs-sys Thu Apr 11 01:23:04 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id BAA23290 for cvs-sys-outgoing; Thu, 11 Apr 1996 01:23:04 -0700 (PDT) Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id BAA23209 Thu, 11 Apr 1996 01:22:43 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by Root.COM (8.7.5/8.6.5) with SMTP id BAA09571; Thu, 11 Apr 1996 01:21:09 -0700 (PDT) Message-Id: <199604110821.BAA09571@Root.COM> X-Authentication-Warning: implode.Root.COM: Host localhost [127.0.0.1] didn't use HELO protocol To: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/net slcompress.c In-reply-to: Your message of "Thu, 11 Apr 1996 11:32:15 +0400." <199604110732.LAA01702@astral.msk.su> From: David Greenman Reply-To: davidg@Root.COM Date: Thu, 11 Apr 1996 01:21:09 -0700 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> davidg 96/04/10 23:46:26 >> >> Modified: sys/net slcompress.c >> Log: >> When cslip gets an uncompressed packet, it attempts to save off the TCP/IP >> header for use in decompressing subsequant packets. If cslip gets garbage >> (such as what happens when there is a port speed mismatch or modem line >> noise), it will occasionally mistake the packet as a valid uncompressed >> packet. When it tries to save off the header, it doesn't bother to check >> for the validity of the header length and will happily clobber not only >> the cslip data structure, but parts of other kernel memory that happens >> to follow it...causing, ahem, undesired behavior. > >David, can you please also fix it in usr.sbin/ppp/slcompress.c? >(if the bug present there) Yes, I was editing the file when you sent this. ...done. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project