From owner-freebsd-mips@FreeBSD.ORG  Tue Jan 25 15:25:13 2011
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F363D106566B
	for <freebsd-mips@freebsd.org>; Tue, 25 Jan 2011 15:25:12 +0000 (UTC)
	(envelope-from aduane@juniper.net)
Received: from exprod7og115.obsmtp.com (exprod7og115.obsmtp.com [64.18.2.217])
	by mx1.freebsd.org (Postfix) with ESMTP id 5CE0D8FC1E
	for <freebsd-mips@freebsd.org>; Tue, 25 Jan 2011 15:25:11 +0000 (UTC)
Received: from source ([66.129.224.36]) (using TLSv1) by
	exprod7ob115.postini.com ([64.18.6.12]) with SMTP
	ID DSNKTT7rVsWJAdHkyj0jL2YF2Ohz/emDl0vZ@postini.com;
	Tue, 25 Jan 2011 07:25:12 PST
Received: from p-emfe02-wf.jnpr.net (172.28.145.25) by P-EMHUB03-HQ.jnpr.net
	(172.24.192.37) with Microsoft SMTP Server (TLS) id 8.2.254.0;
	Tue, 25 Jan 2011 07:20:28 -0800
Received: from EMBX01-WF.jnpr.net ([fe80::1914:3299:33d9:e43b]) by
	p-emfe02-wf.jnpr.net ([fe80::c126:c633:d2dc:8090%11]) with mapi;
	Tue, 25 Jan 2011 10:20:28 -0500
From: Andrew Duane <aduane@juniper.net>
To: Jayachandran C. <c.jayachandran@gmail.com>, "freebsd-mips@freebsd.org"
	<freebsd-mips@freebsd.org>
Date: Tue, 25 Jan 2011 10:18:23 -0500
Thread-Topic: [PATCH] update sf_buf and uio for n64
Thread-Index: Acu8lpkQO8wj6H9KSKeTLmpR3OdJegADIJJr
Message-ID: <AC6674AB7BC78549BB231821ABF7A9AE91C1B58E19@EMBX01-WF.jnpr.net>
References: <AANLkTik+pMOxCaD70oZJPsmKa4mNCviZmzLhxe8wQR-y@mail.gmail.com>
In-Reply-To: <AANLkTik+pMOxCaD70oZJPsmKa4mNCviZmzLhxe8wQR-y@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: 
Subject: RE: [PATCH] update sf_buf and uio for n64
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2011 15:25:13 -0000

A minor comment/question, from someone just getting up to speed on the MIPS=
 ports here.

Would it be slightly cleaner to use the sf_buf_page routine in sf_buf_kva, =
rather than a duplicated cast? It would clarify the use a little. I am assu=
ming the sf_buf_page is an inline routine rather than a #define to match th=
e 32-bit API?

--
Andrew Duane             Juniper Networks
978-589-0551              10 Technology Park Dr
aduane@juniper.net      Westford, MA  01886-3418

________________________________________
From: owner-freebsd-mips@freebsd.org [owner-freebsd-mips@freebsd.org] On Be=
half Of Jayachandran C. [c.jayachandran@gmail.com]
Sent: Tuesday, January 25, 2011 8:48 AM
To: freebsd-mips@freebsd.org
Subject: [PATCH] update sf_buf and uio for n64

This is one of the remaining pieces in n64 work from Juli's octeon
branch. The attached patch updates the sf_buf code and uio_machdep.c
in n64 compilation to use direct mapping.

Planning to check this in later this week, if there are no objections.

JC.