From owner-cvs-all@FreeBSD.ORG  Tue Jul 22 03:47:20 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E5F6D37B401; Tue, 22 Jul 2003 03:47:20 -0700 (PDT)
Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BF44E43F3F; Tue, 22 Jul 2003 03:47:19 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h6MAlGV3004229;
	Tue, 22 Jul 2003 10:47:16 GMT
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h6MAlF5H010037;
	Tue, 22 Jul 2003 12:47:16 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Paul Richards <paul@freebsd-services.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 22 Jul 2003 11:45:24 BST."
             <20030722104524.GA80471@survey.codeburst.net> 
Date: Tue, 22 Jul 2003 12:47:15 +0200
Message-ID: <10036.1058870835@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2003 10:47:21 -0000

In message <20030722104524.GA80471@survey.codeburst.net>, Paul Richards writes:
>On Tue, Jul 22, 2003 at 02:22:00AM -0700, Poul-Henning Kamp wrote:
>> phk         2003/07/22 02:22:00 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/dev/lnc          if_lnc.c 
>>   Log:
>>   Don't inline ridiculously very large functions.
>>   
>>   Compared to the contents of these functions, an extra function call
>>   is nano-peanuts.
>
>Both of those functions were called from just one place, inside the
>interrupt handler. Is there any reason to not inline them?

Yes, we need to get -Werror on the kernel again, and GCC whines about
ridiculously large functions.

Inline should not be used unless it has a measurable impact on
performance.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.