From owner-svn-src-projects@FreeBSD.ORG Thu May 5 16:22:57 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 432F11065674; Thu, 5 May 2011 16:22:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id A2F438FC15; Thu, 5 May 2011 16:22:56 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p45GMq4s046441 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 May 2011 19:22:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p45GMqlL077922; Thu, 5 May 2011 19:22:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p45GMqhV077921; Thu, 5 May 2011 19:22:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 May 2011 19:22:52 +0300 From: Kostik Belousov To: mdf@freebsd.org Message-ID: <20110505162252.GX48734@deviant.kiev.zoral.com.ua> References: <201105051439.p45EdEgC003770@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xFQBzfy8IMmn3THN" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Attilio Rao , svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221499 - in projects/largeSMP: gnu/usr.bin/gdb/kgdb lib/libmemstat sys/amd64/acpica sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/cddl/dev/cyclic/i386 sys/cddl/dev/... X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 16:22:57 -0000 --xFQBzfy8IMmn3THN Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 05, 2011 at 08:56:31AM -0700, mdf@freebsd.org wrote: > On Thu, May 5, 2011 at 7:39 AM, Attilio Rao wrote: > > Author: attilio > > Date: Thu May =9A5 14:39:14 2011 > > New Revision: 221499 > > URL: http://svn.freebsd.org/changeset/base/221499 > > > > Log: > > =9ACommit the support for removing cpumask_t and replacing it directly = with > > =9Acpuset_t objects. >=20 > I suppose it's a bit of a bikeshed issue, but I found a few of the > names a little confusing. I'd prefer: >=20 > s/CPU_OVERLAP/CPU_INTERSECT > s/CPU_NAND/CPU_CLRSET (to mirror CPU_CLR) or CPU_SUBTRACT or CPU_DIFFEREN= CE >=20 > Possibly also s/CPU_OR/CPU_SETSET or CPU_UNION. In general I found > the naming a bit confusing since it seemed that, though these are > declared as a set of cpus (cpuset_t) the operation names aren't > set-type operations, like UNION, INTERSECT, DIFFERENCE, etc. >=20 > It looks like the names have been around for a while, but I suspect > they don't see much use until this branch. There is a set of operations on the signal masks that are very similar to the cpuset_t, and at least nand operation is named consistently between them. --xFQBzfy8IMmn3THN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk3CztwACgkQC3+MBN1Mb4j1vgCg8yD8v7zc6LpNy608QlggCJzD gk4AoOgvgOGBmEhxZ/y/e0GoLsd6ZZQT =wQKx -----END PGP SIGNATURE----- --xFQBzfy8IMmn3THN--