From owner-freebsd-arch@FreeBSD.ORG Fri Jul 8 19:26:31 2011 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B9851065674; Fri, 8 Jul 2011 19:26:31 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 46BD38FC1A; Fri, 8 Jul 2011 19:26:29 +0000 (UTC) Received: by ewy1 with SMTP id 1so986139ewy.13 for ; Fri, 08 Jul 2011 12:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=DdZQTKpSzHKHtBK84tQ0YcGy9yXq2UfECMYaTandLn0=; b=Ljo2OKM4wvvtMlfwlnDN2RP39rlUTfn80qJ6eW7xM4bfdUb9AFUkGI3TEh9UAYy8+R 0ETTs9VN6+yvu56Mio/LqmVe1CsDpbh8XfvYndV2VDgIMSxW3hZAraOAzDorTO0cuqyt owtn3VlAlC+xyF9er6crFO2SVIsswz5/Vt4gQ= MIME-Version: 1.0 Received: by 10.213.27.204 with SMTP id j12mr806185ebc.25.1310151674190; Fri, 08 Jul 2011 12:01:14 -0700 (PDT) Received: by 10.213.7.142 with HTTP; Fri, 8 Jul 2011 12:01:14 -0700 (PDT) In-Reply-To: References: <20110708164844.GZ48734@deviant.kiev.zoral.com.ua> <201107081314.44128.jhb@freebsd.org> Date: Fri, 8 Jul 2011 15:01:14 -0400 Message-ID: From: Ryan Stone To: Peter Wemm Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Kostik Belousov , Attilio Rao , Sergey Kandaurov , freebsd-arch@freebsd.org Subject: Re: [PATCH] Add MAXCPU as a kernel config option and quality discussion on this X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2011 19:26:31 -0000 On Fri, Jul 8, 2011 at 2:22 PM, Peter Wemm wrote: > Yes, having a default value for sizing cpuset_t does look harmful if a > kld module tries to use them. =A0What is currently in the tree will > silently fail by successfully compiling for kld modules that try to > use anything affected by that. Could we implicitly add something like MODULE_DEPEND(maxcpu, MAXCPU, MAXCPU, MAXCPU); to every kld module so that we reject modules compiled with the wrong MAXCPU value? Maybe add it to DECLARE_MODULE or something.