From owner-freebsd-current@FreeBSD.ORG Thu Dec 1 01:21:39 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52A17106566C; Thu, 1 Dec 2011 01:21:39 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id D02338FC12; Thu, 1 Dec 2011 01:21:38 +0000 (UTC) Received: by ywp17 with SMTP id 17so2015763ywp.13 for ; Wed, 30 Nov 2011 17:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=yG0BVYqicCJVLxOUIgutgs7NXtj145hCWf22HHc7Cy4=; b=CntwAULpFIhyJKLVJB3ogEdBlBU/xpH4giSsUTbftyMcuuGPL5l2nCSNkT4tyXJ8Xi flvXSNTYKubly3y+qfILhcqMm2oOgNTkznmZBf+2Mcrtb0MMczoMPhYoHbNxXNf7TUjZ MgQqKx4toeynzjTUhMxCzPXTOLtcgWkx4AVmI= MIME-Version: 1.0 Received: by 10.182.40.65 with SMTP id v1mr979867obk.72.1322702498107; Wed, 30 Nov 2011 17:21:38 -0800 (PST) Received: by 10.182.62.227 with HTTP; Wed, 30 Nov 2011 17:21:37 -0800 (PST) In-Reply-To: <20111201002515.GA50028@freebsd.org> References: <201111291607.26546.jhb@freebsd.org> <20111201002515.GA50028@freebsd.org> Date: Wed, 30 Nov 2011 17:21:37 -0800 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Doug Barton , Warner Losh , current@freebsd.org, Warner Losh Subject: Re: Remove debug echo X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 01:21:39 -0000 On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best wrote= : > On Tue Nov 29 11, Warner Losh wrote: >> kill it. >> >> Warner >> On Nov 29, 2011, at 2:07 PM, John Baldwin wrote: >> >> > Any objections to this? =A0It removes a weird line during 'make -s bui= ldworld' >> > output and I think it was debugging accidentally left in in 213077 by = Warner: >> > >> > Index: newvers.sh >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > --- newvers.sh =A0 =A0 =A0(revision 228074) >> > +++ newvers.sh =A0 =A0 =A0(working copy) >> > @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do >> > done >> > >> > if [ -n "$svnversion" ] ; then >> > - =A0 echo "$svnversion" >> > =A0 =A0 svn=3D`cd ${SYSDIR} && $svnversion` >> > =A0 =A0 case "$svn" in >> > =A0 =A0 [0-9]*) svn=3D" r${svn}" ;; > > also... > > when running buildkernel via 'make -s', do we really need all those modul= e > printfs? i see messages for "cleandir", "obj", "depend" and "all". i thin= k for > 'make -s', that's pure overkill! > > for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 = and > you'll get 2680 lines of output. not really *silent*, is it? ;) pmake sucks as far as diagnostic output is concerned when compared with gmake. I'd rather not have to fish through with -j1 (if I'm lucky and it's not a race) to determine what directory created the "Error Code" output. With the printouts discussed here, at least you have a chance at determining what the issue was. Maybe it's just me, but I like noisy builds -- otherwise the amount of time I have to spend root-causing the issue becomes expensive. Thanks, -Garrett