From owner-freebsd-bugs@freebsd.org Wed Jan 30 13:35:03 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 931C314C13BB for ; Wed, 30 Jan 2019 13:35:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 29C706C3D2 for ; Wed, 30 Jan 2019 13:35:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E05CF14C13B9; Wed, 30 Jan 2019 13:35:02 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDB8014C13B8 for ; Wed, 30 Jan 2019 13:35:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 594276C3CF for ; Wed, 30 Jan 2019 13:35:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 95AAD1FB5B for ; Wed, 30 Jan 2019 13:35:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0UDZ145035261 for ; Wed, 30 Jan 2019 13:35:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0UDZ1we035260 for bugs@FreeBSD.org; Wed, 30 Jan 2019 13:35:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 235318] when updating jails using -b, freebsd-update is reusing host's /var/db/freebsd-update without indication of doing so, unless explicit -d as well Date: Wed, 30 Jan 2019 13:35:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: eto.freebsd@ethome.sk X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 13:35:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235318 Bug ID: 235318 Summary: when updating jails using -b, freebsd-update is reusing host's /var/db/freebsd-update without indication of doing so, unless explicit -d as well Product: Base System Version: 12.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: eto.freebsd@ethome.sk When updating jails from 11.2 to 12.0 I discovered following glitch: It seems that freebsd-update without workdir (-d) specified explicitly, is using host's /var/db/freebsd-update to fetch and store metadata=20 about given jail update. Although this makes perfect logical sense (from certain point of view), I t= hink this breaks a POLA a tiny bit. I was invoking freebsd-update concurrently per two jails like this: 01 sudo \ 02 jname=3D${jname} \ 03 from_version=3D11.1-RELEASE \ 04 to_version=3D12.0-RELEASE \ 05 \ 06 sh -c 'exec freebsd-update \ 07 -b /jails.roots/${jname} \ 08 -f /jails.roots/${jname}/etc/freebsd-update.conf \ 09 --currently-running ${from_version} \ 10 -r ${to_version} upgrade' Both updates failed spectacularly breaking roots of both jail and emitting spurious errors during install phase. I reverted jail roots from zfs snapshots and tried again several times unti= l I discovered that each jail:/var/db/freebsd-update is empty.=20 rming host:/var/db/freebsd-update and running jail updates again seemed to populate only host:/var/db/freebsd-update, jail:/var/db/freebsd-update seem= ed to be left intact (eg. empty). My guess became that both runs of freebsd-update write to same host:/var/db/freebsd-update trampling each other's progress, ignoring jail's data dir. Re-reading manual page very carefully, I finally realized why there is -d.= =20 It would be nice if during invocation with custom basedir, -b, (and perhaps= -d ,or even without -d) freebsd-update detected this invocation and emitted sh= ort summary akin to: > using basedir (-b) : /bla/bla/bla > using workdir (-d) : /ble/ble/ble > notice: workdir is not subdir of basedir ! This would lessen any surprises.=20 One might argue that explicit basedir specification should offset workdir as well, unless workdir is explicitly set, but that lies in the eye of beholde= r. Short notice would at least make operator aware what is freebsd-update goin= g to do. Once root cause was found, fix was easy: 01 sudo \ 02 jname=3D${jname} \ 03 from_version=3D11.1-RELEASE \ 04 to_version=3D12.0-RELEASE \ 05 \ 06 sh -c 'exec freebsd-update \ 07 -b /jails.roots/${jname} \ 08 -d /jails.roots/${jname}/var/db/freebsd-update \ 09 -f /jails.roots/${jname}/etc/freebsd-update.conf \ 10 --currently-running ${from_version} \ 11 -r ${to_version} upgrade' Still, it would be nice, if freebsd-update was more friendly in this regard. --=20 You are receiving this mail because: You are the assignee for the bug.=