From owner-cvs-all Mon Jul 23 22: 7: 8 2001 Delivered-To: cvs-all@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 2298E37B403; Mon, 23 Jul 2001 22:07:00 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 2E8A03E2F; Mon, 23 Jul 2001 22:06:58 -0700 (PDT) To: Garance A Drosihn Cc: Greg Lehey , Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/atrun atrun.c In-Reply-To: ; from drosih@rpi.edu on "Mon, 23 Jul 2001 21:30:44 -0400" Date: Mon, 23 Jul 2001 22:06:58 -0700 From: Dima Dorfman Message-Id: <20010724050658.2E8A03E2F@bazooka.unixfreak.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Garance A Drosihn writes: > At 9:08 AM +0930 7/24/01, Greg Lehey wrote: > >On Monday, 23 July 2001 at 5:05:27 -0700, Kris Kennaway wrote: > >> kris 2001/07/23 05:05:27 PDT > >> Log: > >> s/adress/address/ > > > >Do we really need this detail in the log message? That's what > >diffs are for. > > If you are questioning the log message, then the issue is "What > are log messages for?". The log message is supposed to give a > short but informative summary of what the change is. These > log messages are informative, and it's hard to imagine how they > could be any shorter. Sounds like a good log message to me. Actually, I think log messages should explain the rationale behind the commit. Everyone can see *what* was changed by looking at the diffs; it's the *why* that's important in the long run, and what's going to help somebody find and fix a bug a year from now. Of course, the rationale for fixing a typo or warning is understood, so falling back to things like "oops" (an OpenBSD favorite), "fix typo", or what Kris did is quite appropriate. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message