Date: Mon, 23 Jul 2001 22:06:58 -0700 From: Dima Dorfman <dima@unixfreak.org> To: Garance A Drosihn <drosih@rpi.edu> Cc: Greg Lehey <grog@FreeBSD.org>, Kris Kennaway <kris@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/libexec/atrun atrun.c Message-ID: <20010724050658.2E8A03E2F@bazooka.unixfreak.org> In-Reply-To: <p0510100db7827da58818@[128.113.24.47]>; from drosih@rpi.edu on "Mon, 23 Jul 2001 21:30:44 -0400"
next in thread | previous in thread | raw e-mail | index | archive | help
Garance A Drosihn <drosih@rpi.edu> writes: > At 9:08 AM +0930 7/24/01, Greg Lehey wrote: > >On Monday, 23 July 2001 at 5:05:27 -0700, Kris Kennaway wrote: > >> kris 2001/07/23 05:05:27 PDT > >> Log: > >> s/adress/address/ > > > >Do we really need this detail in the log message? That's what > >diffs are for. > > If you are questioning the log message, then the issue is "What > are log messages for?". The log message is supposed to give a > short but informative summary of what the change is. These > log messages are informative, and it's hard to imagine how they > could be any shorter. Sounds like a good log message to me. Actually, I think log messages should explain the rationale behind the commit. Everyone can see *what* was changed by looking at the diffs; it's the *why* that's important in the long run, and what's going to help somebody find and fix a bug a year from now. Of course, the rationale for fixing a typo or warning is understood, so falling back to things like "oops" (an OpenBSD favorite), "fix typo", or what Kris did is quite appropriate. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010724050658.2E8A03E2F>