From owner-svn-src-stable@FreeBSD.ORG Sun Mar 1 04:30:47 2015 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DAFB5491; Sun, 1 Mar 2015 04:30:47 +0000 (UTC) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A2D64C24; Sun, 1 Mar 2015 04:30:47 +0000 (UTC) Received: by igbhl2 with SMTP id hl2so9765433igb.3; Sat, 28 Feb 2015 20:30:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LEk3XyIgVCGhjBJs2eJ5NJDmAZrXWkvD1XKwejLQu1Y=; b=DffVUtzeyVZu2aKL2GJhTgZn8qbfy0Nj+5FspEY6exxgnXE0tn9LSWM17q7fk+TYfM UD7e2olweo0AUlFJu2HYUbs9Y8DncmAVYAA2JNcoxH+lLRTFv8qGAi41qO/2D+ya5j+g gUU0eYpH0d7QMz15J73fXAw14v5TvazfHwwcEHKCZE7Zv/CtrSyZrcEubLSwrqTt7BlA PWib9mh/hTvkAXw0byLEwy+SAhawTm40xo7F6KGThCstijuBdlnZrhi6Lzw8R0Sqyr3D XWbEzYKyA81uZAIogZv7xvHDQAiPxppPlNIW8KDbgqHh97o5qa0PPgkKEyVSyPUGHQD6 A3wQ== MIME-Version: 1.0 X-Received: by 10.42.150.130 with SMTP id a2mr24181580icw.69.1425184246917; Sat, 28 Feb 2015 20:30:46 -0800 (PST) Received: by 10.107.156.75 with HTTP; Sat, 28 Feb 2015 20:30:46 -0800 (PST) In-Reply-To: <201503010426.t214Qm0d000607@svn.freebsd.org> References: <201503010426.t214Qm0d000607@svn.freebsd.org> Date: Sat, 28 Feb 2015 23:30:46 -0500 Message-ID: Subject: Re: svn commit: r279471 - stable/10/sys/dev/pci From: Ryan Stone To: Ryan Stone Content-Type: text/plain; charset=UTF-8 Cc: svn-src-stable@freebsd.org, "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , svn-src-stable-10@freebsd.org X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2015 04:30:48 -0000 On Sat, Feb 28, 2015 at 11:26 PM, Ryan Stone wrote: > Author: rstone > Date: Sun Mar 1 04:26:47 2015 > New Revision: 279471 > URL: https://svnweb.freebsd.org/changeset/base/279471 > > Log: > MFC r264091 > > Correct a PCI enumeration bug introduced in r264011 > > Ensure that first_func is set to 0 on every iteration of the PCI slot > enumeration loop after the first. There is a continue statement that would > cause first_func to stay at 1 any PCI device where slot 0 has no functions > until we find a slot that does have a function. This would cause us to > not enumerate the first PCI function on the device. > > Credit to markj@ for spotting the bug. > > X-MFC-With: r264011 So I didn't get an MFC notice for this one (and I very nearly forgot to MFC it, which would have been fairly disastrous for somebody :( ). Is my understanding of the X-MFC-With: tag incorrect? I thought that setting it would cause me to get a reminder at the same time as r264011