From owner-freebsd-bugs@FreeBSD.ORG Mon May 10 03:10:23 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB81216A4CF for ; Mon, 10 May 2004 03:10:23 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE9FF43D48 for ; Mon, 10 May 2004 03:10:22 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i4AAAM4a051236 for ; Mon, 10 May 2004 03:10:22 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4AAAMtM051235; Mon, 10 May 2004 03:10:22 -0700 (PDT) (envelope-from gnats) Resent-Date: Mon, 10 May 2004 03:10:22 -0700 (PDT) Resent-Message-Id: <200405101010.i4AAAMtM051235@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Flemming Jacobsen Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9E3916A4CE for ; Mon, 10 May 2004 03:05:44 -0700 (PDT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7001343D3F for ; Mon, 10 May 2004 03:05:44 -0700 (PDT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i4AA5hNt061648 for ; Mon, 10 May 2004 03:05:43 -0700 (PDT) (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id i4AA5fpQ061646; Mon, 10 May 2004 03:05:41 -0700 (PDT) (envelope-from nobody) Message-Id: <200405101005.i4AA5fpQ061646@www.freebsd.org> Date: Mon, 10 May 2004 03:05:41 -0700 (PDT) From: Flemming Jacobsen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/66445: Add options ti last to ignore ftp logins (usefull for busy ftp servers) [PATCH] X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2004 10:10:23 -0000 >Number: 66445 >Category: misc >Synopsis: Add options ti last to ignore ftp logins (usefull for busy ftp servers) [PATCH] >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon May 10 03:10:22 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Flemming Jacobsen >Release: 5.2.1-RELEASE-p3 >Organization: DKUUG >Environment: FreeBSD ra.dkuug.dk 5.2.1-RELEASE-p3 FreeBSD 5.2.1-RELEASE-p3 #1: Fri Mar 19 05:46:43 CET 2004 fj@nyra.dkuug.dk:/usr/obj/usr/src/sys/RA i386 >Description: On a busy ftp server last is almost useless wothout using some kind of grep -v, if wou want to know about your co-admins. >How-To-Repeat: do 'last -10' on a busy ftp server. Observe that no "shell-logins" are seen. >Fix: A patch to fix this is located at: http://www.batmule.dk/FreeBSD/last.ignoreftp.diff It's pasted below for competeness: --- last.1.orig Mon May 10 11:10:40 2004 +++ last.1 Mon May 10 11:35:54 2004 @@ -145,6 +145,12 @@ .It Fl h Ar host .Ar Host names may be names or internet numbers. +.It Fl i +Ignore all anonymous ftp logins while displaying. +This is usefull on a busy ftp server. +.It Fl I +Ignore all ftp logins while displaying. +This is usefull on a busy ftp server. .It Fl n Ar maxrec Limit the report to .Ar maxrec --- last.c.orig Mon May 10 11:10:34 2004 +++ last.c Mon May 10 11:52:34 2004 @@ -98,6 +98,11 @@ * report users logged in * at this snapshot time */ +static int ignoreftp=0; /* if == 1, ignore annonymous + * ftp logins + * if ==2, ignore all ftp + * logins + */ void addarg(int, char *); time_t dateconv(char *); @@ -114,7 +119,7 @@ usage(void) { (void)fprintf(stderr, -"usage: last [-swy] [-d [[CC]YY][MMDD]hhmm[.SS]] [-f file] [-h host]\n" +"usage: last [-iIswy] [-d [[CC]YY][MMDD]hhmm[.SS]] [-f file] [-h host]\n" " [-n maxrec] [-t tty] [user ...]\n"); exit(1); } @@ -130,7 +135,7 @@ maxrec = -1; snaptime = 0; - while ((ch = getopt(argc, argv, "0123456789d:f:h:n:st:wy")) != -1) + while ((ch = getopt(argc, argv, "0123456789d:f:h:iIn:st:wy")) != -1) switch (ch) { case '0': case '1': case '2': case '3': case '4': case '5': case '6': case '7': case '8': case '9': @@ -157,6 +162,12 @@ hostconv(optarg); addarg(HOST_TYPE, optarg); break; + case 'i': + ignoreftp=1; + break; + case 'I': + ignoreftp=2; + break; case 'n': errno = 0; maxrec = strtol(optarg, &p, 10); @@ -336,6 +347,10 @@ time_t delta; /* time difference */ time_t t; + if( !strcmp("ftp",bp->ut_name) && ignoreftp) /* anon ftp */ + return; + if( !strcmp("ftp",bp->ut_line) && ignoreftp == 2) /* ftp */ + return; if (maxrec != -1 && !maxrec--) exit(0); t = _int_to_time(bp->ut_time); >Release-Note: >Audit-Trail: >Unformatted: