From owner-cvs-src Wed Feb 12 7:42: 1 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32CDA37B401; Wed, 12 Feb 2003 07:41:59 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3ACEE43F3F; Wed, 12 Feb 2003 07:41:57 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id CAA29984; Thu, 13 Feb 2003 02:41:54 +1100 Date: Thu, 13 Feb 2003 02:42:15 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Warner Losh Cc: src-committers@FreeBSD.org, , Subject: Re: cvs commit: src/sys/sys rman.h src/sys/kern subr_rman.c In-Reply-To: <200302120701.h1C710AK063732@repoman.freebsd.org> Message-ID: <20030213023337.N8859-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 11 Feb 2003, Warner Losh wrote: > imp 2003/02/11 23:01:00 PST > > Modified files: > sys/sys rman.h > sys/kern subr_rman.c > Log: > Implement rman_get_device > > # I though this was alredy implemented > > Pointy hat on my head shown by: peter > > Revision Changes Path > 1.29 +6 -0 src/sys/kern/subr_rman.c > 1.19 +1 -0 src/sys/sys/rman.h I thought that the original bug was caused by rman implementing simple-to- implement interfaces like this using macros (and thus having to export its internals). It now uses functions for all function-like interfaces, but it still exports the internals. One of the internals is the layering violation of depending on bus space typedefs. All clients have to know about this and include before . Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message