Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Feb 2003 02:42:15 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, <cvs-src@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/sys rman.h src/sys/kern subr_rman.c
Message-ID:  <20030213023337.N8859-100000@gamplex.bde.org>
In-Reply-To: <200302120701.h1C710AK063732@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 11 Feb 2003, Warner Losh wrote:

> imp         2003/02/11 23:01:00 PST
>
>   Modified files:
>     sys/sys              rman.h
>     sys/kern             subr_rman.c
>   Log:
>   Implement rman_get_device
>
>   # I though this was alredy implemented
>
>   Pointy hat on my head shown by: peter
>
>   Revision  Changes    Path
>   1.29      +6 -0      src/sys/kern/subr_rman.c
>   1.19      +1 -0      src/sys/sys/rman.h

I thought that the original bug was caused by rman implementing simple-to-
implement interfaces like this using macros (and thus having to export its
internals).  It now uses functions for all function-like interfaces, but it
still exports the internals.

One of the internals is the layering violation of depending on bus space
typedefs.  All clients have to know about this and include <machine/bus.h>
before <sys/rmain.h>.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030213023337.N8859-100000>