From owner-svn-src-head@freebsd.org  Tue Dec  8 16:12:08 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F06D09D4117;
 Tue,  8 Dec 2015 16:12:08 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net
 [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f])
 by mx1.freebsd.org (Postfix) with ESMTP id D9BAB1878;
 Tue,  8 Dec 2015 16:12:08 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from sweettea.beer.town (unknown [76.164.8.130])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id D670F56489;
 Tue,  8 Dec 2015 10:12:01 -0600 (CST)
Subject: Re: svn commit: r289315 - in head: include lib/libc/resolv
 share/man/man5
To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
References: <201510141426.t9EEQiWX079418__45653.4197823659$1444832818$gmane$org@repo.freebsd.org>
 <86r3j06d0v.fsf@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Eric van Gyzen <vangyzen@FreeBSD.org>
Message-ID: <5667014E.1040209@FreeBSD.org>
Date: Tue, 8 Dec 2015 10:11:58 -0600
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <86r3j06d0v.fsf@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Dec 2015 16:12:09 -0000

On 12/05/2015 11:06, Raphael Kubo da Costa wrote:
> Eric van Gyzen <vangyzen@FreeBSD.org> writes:
>
>> Author: vangyzen
>> Date: Wed Oct 14 14:26:44 2015
>> New Revision: 289315
>> URL: https://svnweb.freebsd.org/changeset/base/289315
>>
>> Log:
>>   resolver: automatically reload /etc/resolv.conf
>>
>> [...]
>>
>> Modified: head/include/resolv.h
>> ==============================================================================
>> --- head/include/resolv.h	Wed Oct 14 12:46:05 2015	(r289314)
>> +++ head/include/resolv.h	Wed Oct 14 14:26:44 2015	(r289315)
>>
>> [...]
>>
>> @@ -188,6 +189,8 @@ struct __res_state {
>>  		} _ext;
>>  	} _u;
>>  	u_char	*_rnd;			/*%< PRIVATE: random state */
>> +	struct timespec	conf_mtim;	/*%< mod time of loaded resolv.conf */
>> +	time_t		conf_stat;	/*%< time of last stat(resolv.conf) */
>>  };
> With this change, including the headers listed in resolver(3),
> sys/types.h, netinet/in.h, arpa/nameser.h and resolv.h is not enough, as
> resolv.h now depends on sys/time.h. This has broken at least one port,
> net-mgmt/sx. It includes those 4 headers to find if the resolver library
> is in libc. The test program fails like this:
>
> In file included from conftest.c:31:
> /usr/include/resolv.h:192:18: error: field has incomplete type 'struct timespec'
>         struct timespec conf_mtim;      /*%< mod time of loaded resolv.conf */
>                         ^
> /usr/include/resolv.h:192:9: note: forward declaration of 'struct timespec'
>         struct timespec conf_mtim;      /*%< mod time of loaded resolv.conf */
>                ^

Thanks for the detailed report, Raphael.  It's fixed in head r291994.

Eric