From owner-cvs-all Wed Feb 21 13:12: 2 2001 Delivered-To: cvs-all@freebsd.org Received: from freesbee.wheel.dk (freesbee.wheel.dk [193.162.159.97]) by hub.freebsd.org (Postfix) with ESMTP id A20D037B491; Wed, 21 Feb 2001 13:11:52 -0800 (PST) (envelope-from jesper@skriver.dk) Received: by freesbee.wheel.dk (Postfix, from userid 1001) id 992D53E6A; Wed, 21 Feb 2001 22:11:51 +0100 (CET) Date: Wed, 21 Feb 2001 22:11:51 +0100 From: Jesper Skriver To: Ben Smithurst Cc: Poul-Henning Kamp , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <20010221221151.L75376@skriver.dk> References: <200102211210.f1LCAKN41997@freefall.freebsd.org> <1166.982760630@critter> <20010221201615.A25231@comp.leeds.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010221201615.A25231@comp.leeds.ac.uk>; from csxbcs@comp.leeds.ac.uk on Wed, Feb 21, 2001 at 08:16:16PM +0000 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Feb 21, 2001 at 08:16:16PM +0000, Ben Smithurst wrote: > Poul-Henning Kamp wrote: > > > Better, and more readable: > > > > error = function(a1, a2); > > if (error != 0) > > Well that's a matter of opinion, but I suppose it's easily changed. :-) > I figured there's enough use of 'if ((var = func()) != 0)' in FreeBSD > that everyone knows exactly what it does and yours isn't really any more > readable. But it can easily be changed if people generally agree with > you. Me newbee think phk's version is much more readable ... /Jesper -- Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456 Work: Network manager @ AS3292 (Tele Danmark DataNetworks) Private: FreeBSD committer @ AS2109 (A much smaller network ;-) One Unix to rule them all, One Resolver to find them, One IP to bring them all and in the zone to bind them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message