From owner-svn-src-all@FreeBSD.ORG Mon Sep 20 19:51:36 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F342310656A3; Mon, 20 Sep 2010 19:51:35 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from mx0.hoeg.nl (unknown [IPv6:2a01:4f8:101:5343::aa]) by mx1.freebsd.org (Postfix) with ESMTP id 878EE8FC14; Mon, 20 Sep 2010 19:51:35 +0000 (UTC) Received: by mx0.hoeg.nl (Postfix, from userid 1000) id DED172A28D3B; Mon, 20 Sep 2010 21:51:34 +0200 (CEST) Date: Mon, 20 Sep 2010 21:51:34 +0200 From: Ed Schouten To: Bruce Evans Message-ID: <20100920195134.GS56986@hoeg.nl> References: <201009191635.o8JGZgF3008282@svn.freebsd.org> <20100920224337.E63497@besplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qBOV/12gVmFoc0GF" Content-Disposition: inline In-Reply-To: <20100920224337.E63497@besplex.bde.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r212867 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2010 19:51:36 -0000 --qBOV/12gVmFoc0GF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Bruce Evans wrote: > Er, my review explained how wrong this is. Please back it out. So basically you want to have it in its current form, with the only difference that CLOCAL is not enforced for callout devices, but still want callout devices to skip waiting for DCD? If so, I can change that if you like. About the default flags for serial devices. I really have no idea how to sanely address the issue you're raising. Isn't it a good thing that right now we initialize all termios structures similarly? It makes the system far more predictive than pushing that logic into the driver. Also, I don't think "breaking historical behaviour" should always be considered a bug, which is often something you seem to imply. Look, I am more than willing to get things improved in the TTY layer, but please, just create a patch. In the same (probably even less) time you've written your email, you could have simply crafted a patch and sent it to me. That way it is practically impossible for us to miscommunicate and it saves me a lot of time. --=20 Ed Schouten WWW: http://80386.nl/ --qBOV/12gVmFoc0GF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAkyXu0YACgkQ52SDGA2eCwVGCgCdHlt/ZDJPoszLQu8+R9aEk6Ph Fn0An3HR7ZE7FIE+GGzRSFJe/6LPUHKG =MdUK -----END PGP SIGNATURE----- --qBOV/12gVmFoc0GF--