Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Dec 2023 05:09:25 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 275958] benchmarks/stress-ng: namespace collision for crypt_data if libxcrypt installed
Message-ID:  <bug-275958-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275958

            Bug ID: 275958
           Summary: benchmarks/stress-ng: namespace collision for
                    crypt_data if libxcrypt installed
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: pizzamig@freebsd.org
          Reporter: jcfyecrayz@liamekaens.com
             Flags: maintainer-feedback?(pizzamig@freebsd.org)
          Assignee: pizzamig@freebsd.org

Created attachment 247278
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247278&action=
=3Dedit
[patch] avoid conflicting crypt_data definitions (crypt.h vs unistd.h)

If libxcrypt is installed, the build for benchmarks/stress-ng fails (after =
the
recent update to 0.17.03 - but it failed with 0.16.02, too).

 .
 .
cc -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -Wall -Wextra -DVERSION=3D'"0.17.03"' -std=3Dgnu99
-fstack-protector-strong -Werror=3Dformat-security -U_FORTIFY_SOURCE
-D_FORTIFY_SOURCE=3D2 -c -o stress-cyclic.o stress-cyclic.c
In file included from stress-crypt.c:24:
/usr/local/include/crypt.h:73:8: error: redefinition of 'crypt_data'
struct crypt_data
       ^
/usr/include/unistd.h:489:8: note: previous definition is here
struct crypt_data {
       ^
1 error generated.
gmake[2]: *** [Makefile:618: stress-crypt.o] Error 1


The attached patch fixes this by preventing the build from using
<localbase>/include/crypt.h

While here, the patch adds do-configure so that the configure is a separate
step than 'make build'.  This is more typical of the way most FreeBSD ports
work.  But this change is not required to fix the crypt_data namespace
conflict.

No need for PORTREVISION bump as the resulting package is the same before a=
nd
after the change (assuming your port build did not fail because of the prob=
lem
described here).

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-275958-7788>