From nobody Sat Jan 20 18:49:20 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4THQWN6yzMz56Vq8; Sat, 20 Jan 2024 18:49:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4THQWN6257z4cpk; Sat, 20 Jan 2024 18:49:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705776560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SwKx/J27GKO9lHWiQiPgE2HHSZiFsimXNKSaBSZW1fI=; b=H2pfiNWXshDS1MyBwhAM4To5mybttr77FhcJ1yaMzBWmk02J9qLBPXg/n83sjyXEaKpzvc /Yet0mHcbLcOTpEVImxD7FGAqoglMQtPprJo89XY7PlOO++05Vx1QBE0jiXPNalIvRjcjM Wa/5aHTq3dxYtrTrdKylw2OdkX4V3uWBKBGtoXSVzsYhh0SSn+1ilduXCqJ4RHVPlQZ2IS 3pr/ZpkBirADVHlShngjApcFA5rHiA0IuOfjNsiNg+t5QLHqucK6ieANhW3ijeuSQN5X/1 cL+TLjk32YQFfyCV5e2eHz8cWJZK/Zch+rQShROYEq9m047xEIfhL/xwjNfKdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705776560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SwKx/J27GKO9lHWiQiPgE2HHSZiFsimXNKSaBSZW1fI=; b=QzdXt7H69S1YGv8W2b5+qI2HLLpDowXfkw8bn8fBbI3cosIXdjx3l0qx4VQf1sd/UVgS59 4Nl8F8tpG381alQK7UR5HfTqtjvXg1MP742cUVHrrtBo8x93jr2QQ7KiVZCZesy4yPCdh2 VhSnGZ1rlLWnoCUW5do0dgw7N4aISEGQA1tObUjJ5MI6ECBxVSIiGrnPK/gOyRHsTSLIwE eTy78FZLFQpI7TvZNiYOnXtV9PApJkXJdW+usKjHabA+Up1OCQSdRQQ9FON0g1COb+r0Ln R8fEedQxJaZERHdDjfesHITFVgO1evKIwAlJMefKBxYzx/0VugKkhH6T8sw9yA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705776560; a=rsa-sha256; cv=none; b=keuhLeQDglFlgKRnKuQWBx5AekIDAhvc3VHhnJi81hEeILboKcjB2Cbi/zkPoIXXsU8gmc UEpFVBy7CT+81l4+VSx2hGbN7X/OEOD2Jeh9tR+Yzb+n2muj7FbVuYq4jmFCvVjcIsj6J8 iEWXRvIGvZukzBIO+lcjmbg11pSa+z1sWmd343LSOTCX2zagIX6vOnbavwBbre/8itgMaK sRCXFSSh45OtInD5yI+txbku/7EHI4S0DwyI+QVxoR0BsyVmSfjOIsEfy4qLmZNvWMzDlo 0wRlJFhOF694DCcKdfKpwuqFxZG4u9tnYry83inNQTq4RdLBoDAvEQ940TTlAA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4THQWN55jnzm9Q; Sat, 20 Jan 2024 18:49:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40KInK2h072626; Sat, 20 Jan 2024 18:49:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40KInKSK072622; Sat, 20 Jan 2024 18:49:20 GMT (envelope-from git) Date: Sat, 20 Jan 2024 18:49:20 GMT Message-Id: <202401201849.40KInKSK072622@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Fernando =?utf-8?Q?Apestegu=C3=ADa?= Subject: git: d9fc94dd9d42 - main - Scripts/qa.sh: fine tune USES=ssl recommendation List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: fernape X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d9fc94dd9d4227cd78b4f40a0e614c64ca1bbaa8 Auto-Submitted: auto-generated The branch main has been updated by fernape: URL: https://cgit.FreeBSD.org/ports/commit/?id=d9fc94dd9d4227cd78b4f40a0e614c64ca1bbaa8 commit d9fc94dd9d4227cd78b4f40a0e614c64ca1bbaa8 Author: Fernando Apesteguía AuthorDate: 2023-09-21 12:46:10 +0000 Commit: Fernando Apesteguía CommitDate: 2024-01-20 18:47:41 +0000 Scripts/qa.sh: fine tune USES=ssl recommendation Try to avoid the "you need USES=ssl" in ports that provide a libssl.so or libcrypto.so libraries themselves like security/openssl or security/libressl. PR: 270035 Approved by: portmgr (mat@) Differential Revision: https://reviews.freebsd.org/D41973 --- Mk/Scripts/qa.sh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Mk/Scripts/qa.sh b/Mk/Scripts/qa.sh index ddb9ce09e0db..c4b68b67d2c8 100644 --- a/Mk/Scripts/qa.sh +++ b/Mk/Scripts/qa.sh @@ -116,6 +116,7 @@ baselibs() { local found_openssl local file [ "${PKGBASE}" = "pkg" -o "${PKGBASE}" = "pkg-devel" ] && return + while read -r f; do case ${f} in File:\ .*) @@ -136,10 +137,13 @@ baselibs() { done <<-EOF $(list_stagedir_elfs -exec readelf -d {} + 2>/dev/null) EOF - if [ -z "${USESSSL}" -a -n "${found_openssl}" ]; then - warn "you need USES=ssl" - elif [ -n "${USESSSL}" -a -z "${found_openssl}" ]; then - warn "you may not need USES=ssl" + + if ! list_stagedir_elfs | egrep -q 'lib(crypto|ssl).so*'; then + if [ -z "${USESSSL}" -a -n "${found_openssl}" ]; then + warn "you need USES=ssl" + elif [ -n "${USESSSL}" -a -z "${found_openssl}" ]; then + warn "you may not need USES=ssl" + fi fi return ${rc} }