From owner-svn-src-head@freebsd.org Wed Sep 13 15:12:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F943E00A7C; Wed, 13 Sep 2017 15:12:52 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1BED569438; Wed, 13 Sep 2017 15:12:51 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.0.6] (67-0-215-166.albq.qwest.net [67.0.215.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 076C6192892; Wed, 13 Sep 2017 15:12:49 +0000 (UTC) Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys To: Cy Schubert , Ngie Cooper Cc: Stephen Hurd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201709130711.v8D7BlTS003204@slippy.cwsent.com> From: Sean Bruno Message-ID: <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> Date: Wed, 13 Sep 2017 09:12:50 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <201709130711.v8D7BlTS003204@slippy.cwsent.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K3RXSO7fXoxBXqJUE1dpQ1sEQkuJPg1DQ" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 15:12:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K3RXSO7fXoxBXqJUE1dpQ1sEQkuJPg1DQ Content-Type: multipart/mixed; boundary="lalB5jI6dIhQxjTp1UFWH9Jx4OpW69Pfe"; protected-headers="v1" From: Sean Bruno To: Cy Schubert , Ngie Cooper Cc: Stephen Hurd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys References: <201709130711.v8D7BlTS003204@slippy.cwsent.com> In-Reply-To: <201709130711.v8D7BlTS003204@slippy.cwsent.com> --lalB5jI6dIhQxjTp1UFWH9Jx4OpW69Pfe Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable >>> #blamebruno >>> >>> Reviewed by: sbruno >>> Approved by: sbruno (mentor) >>> Sponsored by: Limelight Networks >>> Differential Revision: https://reviews.freebsd.org/D12235 >> >> *gasps at the LoC count and number of changed drivers* >> >> Could someone please better break this up in the future..? >=20 > Agreed. Down the road parsing out individual commits in this jumbo comm= it=20 > will be difficult to parse. IMO this may as well have simply been, impo= rt=20 > from https://github.com/mattmacy/networking/, just like Mr. Torvalds do= es=20 > at kernel.org. I expect to see a commit like this there but not here. C= an=20 > we break this down to its functional commits? >=20 >=20 This ridiculous loc was due to the amount of restructuring needed to get us back to being in sync with our development. The future will not have this big of a commit/change and should be more bite/fun sized. The #blamebruno tag in the commit log was to indicate that this was not something Stephen was doing on his own, but was something that I had induced over the last few months during testing. sean --lalB5jI6dIhQxjTp1UFWH9Jx4OpW69Pfe-- --K3RXSO7fXoxBXqJUE1dpQ1sEQkuJPg1DQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlm5SvJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LZpuwgAy8yZrzJL2sIlt5KN4zKPB3u6sIrdULD0DuYjuG8kV0sZD/jGj0xBsHtM 9KGbkrWVTAfzUQFlXCc+8oi4a4FZBHnD0wubt0t5K++hE+HtkdZIbkF86OUNbrHj i/3x1y1ZgyMsXvlHZA1MMLXTmAIrpxcz0FO37lx4JsM1TLlLGD+ME8pLNHw8ylRL xXfOwle8HMazso8V1Fwtn5zWuV6WOOS5aJFUwXceWMzBbdroA68OJNCzF/Pw2Sxh Un18XphIQ7XHtfipTWpmTlcagws2NA2nZuMh2RZs7DvwNUaJFOze2fcZNJ4qnnLC dnjFpwOknQ/DzBXMexP02PNR7AIbNw== =ACW6 -----END PGP SIGNATURE----- --K3RXSO7fXoxBXqJUE1dpQ1sEQkuJPg1DQ--