From owner-svn-src-all@FreeBSD.ORG  Tue Aug 24 00:13:14 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3C0611065697;
	Tue, 24 Aug 2010 00:13:14 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au
	[211.29.132.190])
	by mx1.freebsd.org (Postfix) with ESMTP id AA0D58FC14;
	Tue, 24 Aug 2010 00:13:13 +0000 (UTC)
Received: from c122-107-127-123.carlnfd1.nsw.optusnet.com.au
	(c122-107-127-123.carlnfd1.nsw.optusnet.com.au [122.107.127.123])
	by mail09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	o7O0CZAs017208
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 24 Aug 2010 10:12:37 +1000
Date: Tue, 24 Aug 2010 10:12:34 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
In-Reply-To: <86y6bxybxc.fsf@ds4.des.no>
Message-ID: <20100824100917.C22315@delplex.bde.org>
References: <201008141434.o7EEYaSA030301@svn.freebsd.org>
	<20100815205724.00007e0f@unknown>
	<86wrrraqk8.fsf@ds4.des.no> <4C7194E6.6080708@andric.com>
	<86y6bxybxc.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="0-127678578-1282608754=:22315"
Cc: Bruce Cran <bruce@cran.org.uk>, src-committers@FreeBSD.org,
	svn-src-all@FreeBSD.org, Bruce Evans <bde@FreeBSD.org>,
	svn-src-head@FreeBSD.org, Dimitry Andric <dimitry@andric.com>
Subject: Re: svn commit: r211304 - head/lib/libutil
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Aug 2010 00:13:14 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-127678578-1282608754=:22315
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 23 Aug 2010, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote:

> Dimitry Andric <dimitry@andric.com> writes:
>> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
>>> Bruce Cran <bruce@cran.org.uk> writes:
>>>> Somewhat related, there are overflow bugs in humanize_number - for
>>>> example df(1) fails to display space from a 100PB filesystem
>>>> correctly.
>>> Patch?  :)
>> Attached.  This makes humanize_number() work properly for all possible
>> int64_t values.
>
> That's awesome!  Any way I can convince you to fix expand_number() as
> well?  I got a detailed explanation of what's wrong with it (both before
> and after my commits) from bde@ (cc:ed) in private correspondence; I can
> forward it to you if he doesn't mind.

OK.

I think the final point was that it should go back to supporting signed
numbers (only), and that means int64_t ones until scientificize^dehumanize^=
W
humanize_number() is fixed to support intmax_t ones.

Bruce
--0-127678578-1282608754=:22315--