From owner-freebsd-bugs@FreeBSD.ORG Wed Apr 21 11:00:39 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 775D316A4CE for ; Wed, 21 Apr 2004 11:00:39 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5917C43D5C for ; Wed, 21 Apr 2004 11:00:39 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i3LI0dbv082843 for ; Wed, 21 Apr 2004 11:00:39 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i3LI0d0E082842; Wed, 21 Apr 2004 11:00:39 -0700 (PDT) (envelope-from gnats) Resent-Date: Wed, 21 Apr 2004 11:00:39 -0700 (PDT) Resent-Message-Id: <200404211800.i3LI0d0E082842@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nikos Ntarmos Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54EA416A4CE for ; Wed, 21 Apr 2004 10:51:18 -0700 (PDT) Received: from diogenis.ceid.upatras.gr (diogenis.ceid.upatras.gr [150.140.141.181]) by mx1.FreeBSD.org (Postfix) with SMTP id 7E27743D60 for ; Wed, 21 Apr 2004 10:51:16 -0700 (PDT) (envelope-from ntarmos@Gatekeeper.ceid.upatras.gr) Received: (qmail 24527 invoked from network); 21 Apr 2004 17:51:14 -0000 Received: from gatekeeper.ceid.upatras.gr (150.140.143.235) by diogenis.ceid.upatras.gr with SMTP; 21 Apr 2004 17:51:14 -0000 Received: by Gatekeeper.ceid.upatras.gr (Postfix, from userid 1001) id DE3DB5E9; Wed, 21 Apr 2004 20:50:58 +0300 (EEST) Message-Id: <20040421175058.DE3DB5E9@Gatekeeper.ceid.upatras.gr> Date: Wed, 21 Apr 2004 20:50:58 +0300 (EEST) From: Nikos Ntarmos To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: ntarmos@ceid.upatras.gr Subject: kern/65857: sched_ule.c doesn't honor P_NOLOAD, leading to high (by one) vm.loadavg X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Nikos Ntarmos List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2004 18:00:39 -0000 >Number: 65857 >Category: kern >Synopsis: sched_ule.c doesn't honor P_NOLOAD, leading to high (by one) vm.loadavg >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 21 11:00:38 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Nikos Ntarmos >Release: FreeBSD 5.2-CURRENT alpha >Organization: NetCINS Lab - CEID - UPatras - Greece >Environment: System: FreeBSD Gatekeeper.ceid.upatras.gr 5.2-CURRENT FreeBSD 5.2-CURRENT #11: Wed Apr 21 03:22:39 EEST 2004 root@Gatekeeper.ceid.upatras.gr:/usr/obj/usr/src/sys/GATEKEEPER alpha >Description: sched_ule.c doesn't honor P_NOLOAD. This results in the system load being reported as "expected-load-plus-one", also refernced in a current@ thread back in January 2004. This is ULE-specific. >How-To-Repeat: Just run CURRENT with 'options SCHED_ULE' and see the system load (as reported by vm.loadavg or userland tools such as top) hovering to 1.00 for an idle system, or to "expected-load-plus-one" in general. >Fix: --- sys/kern/sched_ule.c.orig Wed Apr 21 03:10:29 2004 +++ sys/kern/sched_ule.c Wed Apr 21 03:20:34 2004 @@ -357,7 +357,7 @@ if (class == PRI_TIMESHARE) kseq->ksq_load_timeshare++; kseq->ksq_load++; - if (class != PRI_ITHD) + if (class != PRI_ITHD && (ke->ke_proc->p_flag & P_NOLOAD) == 0) #ifdef SMP kseq->ksq_group->ksg_load++; #else @@ -380,7 +380,7 @@ class = PRI_BASE(ke->ke_ksegrp->kg_pri_class); if (class == PRI_TIMESHARE) kseq->ksq_load_timeshare--; - if (class != PRI_ITHD) + if (class != PRI_ITHD && (ke->ke_proc->p_flag & P_NOLOAD) == 0) #ifdef SMP kseq->ksq_group->ksg_load--; #else >Release-Note: >Audit-Trail: >Unformatted: