Date: Sun, 4 Oct 2015 12:46:49 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: dumbbell@freebsd.org, s3erios@gmail.com Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288653 - in head/sys/dev/drm2: . i915 Message-ID: <20151004094649.GG11284@kib.kiev.ua> In-Reply-To: <201510040745.t947jbp7082807@repo.freebsd.org> References: <201510040745.t947jbp7082807@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 04, 2015 at 07:45:37AM +0000, Adrian Chadd wrote: > * Add missing case statement (gen == 3) in intel_gpu_reset(). This seems to be wrong. The i915 and G33 chipsets do not have registers declared in the 8xx chipset documentation. More, i915 and G33 have different reset procedures. The absence of '3' case was copied from the corresponding Linux kernel. Was this change tested, or is there a reference to upstream where the handling was added in this manner ? > * Replace M_WAITOK with M_NOWAIT when the return value of malloc is checked (may be incorrect). This is also incorrect. At least the modesetting pathes are executed in the syscall context, and sleeping is allowed; the modesetting locks were selected to make sleeping possible. Using nowait causes random syscalls failure where the requests would succeed otherwise.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151004094649.GG11284>