From owner-freebsd-bugs@FreeBSD.ORG Sun Jan 10 14:10:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D0891065670 for ; Sun, 10 Jan 2010 14:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 321A78FC08 for ; Sun, 10 Jan 2010 14:10:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0AEA3LZ072189 for ; Sun, 10 Jan 2010 14:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0AEA3Rh072188; Sun, 10 Jan 2010 14:10:03 GMT (envelope-from gnats) Date: Sun, 10 Jan 2010 14:10:03 GMT Message-Id: <201001101410.o0AEA3Rh072188@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Pedro F. Giffuni" Cc: Subject: Re: bin/142526: Cleanups and updates to newfs_msdos X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Pedro F. Giffuni" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jan 2010 14:10:04 -0000 The following reply was made to PR bin/142526; it has been noted by GNATS. From: "Pedro F. Giffuni" To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Subject: Re: bin/142526: Cleanups and updates to newfs_msdos Date: Sun, 10 Jan 2010 06:06:57 -0800 (PST) --0-1529515083-1263132417=:73967 Content-Type: text/plain; charset=us-ascii Update: Some people (hi Bruce!) have used non-standard bytes/sector successfully in the past so permit formatting of non-standard blocksizes but warn about it. --0-1529515083-1263132417=:73967 Content-Type: application/octet-stream; name=patch-newfs_msdos Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=patch-newfs_msdos ZGlmZiAtcnUgbmV3ZnNfbXNkb3Mub3JpZy9uZXdmc19tc2Rvcy44IG5ld2Zz X21zZG9zL25ld2ZzX21zZG9zLjgKLS0tIG5ld2ZzX21zZG9zLm9yaWcvbmV3 ZnNfbXNkb3MuOAkyMDEwLTAxLTA2IDExOjA2OjAyLjAwMDAwMDAwMCArMDAw MAorKysgbmV3ZnNfbXNkb3MvbmV3ZnNfbXNkb3MuOAkyMDEwLTAxLTA5IDEw OjI1OjEyLjAwMDAwMDAwMCArMDAwMApAQCAtMTE2LDcgKzExNiw3IEBACiAu SXQgRmwgUyBBciBzZWN0b3Itc2l6ZQogTnVtYmVyIG9mIGJ5dGVzIHBlciBz ZWN0b3IuCiBBY2NlcHRhYmxlIHZhbHVlcyBhcmUgcG93ZXJzIG9mIDIKLWlu IHRoZSByYW5nZSAxMjggdGhyb3VnaCAzMjc2OC4KK2luIHRoZSByYW5nZSA1 MTIgdGhyb3VnaCA0MDk2LgogLkl0IEZsIGEgQXIgRkFULXNpemUKIE51bWJl ciBvZiBzZWN0b3JzIHBlciBGQVQuCiAuSXQgRmwgYiBBciBibG9jay1zaXpl CmRpZmYgLXJ1IG5ld2ZzX21zZG9zLm9yaWcvbmV3ZnNfbXNkb3MuYyBuZXdm c19tc2Rvcy9uZXdmc19tc2Rvcy5jCi0tLSBuZXdmc19tc2Rvcy5vcmlnL25l d2ZzX21zZG9zLmMJMjAxMC0wMS0wNiAxMTowNjowMi4wMDAwMDAwMDAgKzAw MDAKKysrIG5ld2ZzX21zZG9zL25ld2ZzX21zZG9zLmMJMjAxMC0wMS0xMCAw ODo1NDoxNS4wMDAwMDAwMDAgKzAwMDAKQEAgLTU1LDYgKzU1LDcgQEAKICNk ZWZpbmUgTlBCCSAgMgkJLyogbmliYmxlcyBwZXIgYnl0ZSAqLwogCiAjZGVm aW5lIERPU01BR0lDICAweGFhNTUJLyogRE9TIG1hZ2ljIG51bWJlciAqLwor I2RlZmluZSBNQVhCUFMJICA0MDk2CQkvKiBtYXhpbXVtIGJ5dGVzIHBlciBz ZWN0b3IgKi8KICNkZWZpbmUgTUlOQlBTCSAgNTEyCQkvKiBtaW5pbXVtIGJ5 dGVzIHBlciBzZWN0b3IgKi8KICNkZWZpbmUgTUFYU1BDCSAgMTI4CQkvKiBt YXhpbXVtIHNlY3RvcnMgcGVyIGNsdXN0ZXIgKi8KICNkZWZpbmUgTUFYTkZU CSAgMTYJCS8qIG1heGltdW0gbnVtYmVyIG9mIEZBVHMgKi8KQEAgLTE2NSwy MCArMTY2LDIzIEBACiAKICNkZWZpbmUgQlBCR0FQIDAsIDAsIDAsIDAsIDAs IDAKIAorI2RlZmluZSBJTklUKGEsIGIsIGMsIGQsIGUsIGYsIGcsIGgsIGks IGopIFwKKyAgICB7IC5icHMgPSBhLCAuc3BjID0gYiwgLnJlcyA9IGMsIC5u ZnQgPSBkLCAucmRlID0gZSwgXAorICAgICAgLnNlYyA9IGYsIC5taWQgPSBn LCAuc3BmID0gaCwgLnNwdCA9IGksIC5oZHMgPSBqLCB9CiBzdGF0aWMgc3Ry dWN0IHsKICAgICBjb25zdCBjaGFyICpuYW1lOwogICAgIHN0cnVjdCBicGIg YnBiOwogfSBjb25zdCBzdGRmbXRbXSA9IHsKLSAgICB7IjE2MCIsICB7NTEy LCAxLCAxLCAyLCAgNjQsICAzMjAsIDB4ZmUsIDEsICA4LCAxLCBCUEJHQVB9 fSwKLSAgICB7IjE4MCIsICB7NTEyLCAxLCAxLCAyLCAgNjQsICAzNjAsIDB4 ZmMsIDIsICA5LCAxLCBCUEJHQVB9fSwKLSAgICB7IjMyMCIsICB7NTEyLCAy LCAxLCAyLCAxMTIsICA2NDAsIDB4ZmYsIDEsICA4LCAyLCBCUEJHQVB9fSwK LSAgICB7IjM2MCIsICB7NTEyLCAyLCAxLCAyLCAxMTIsICA3MjAsIDB4ZmQs IDIsICA5LCAyLCBCUEJHQVB9fSwKLSAgICB7IjY0MCIsICB7NTEyLCAyLCAx LCAyLCAxMTIsIDEyODAsIDB4ZmIsIDIsICA4LCAyLCBCUEJHQVB9fSwgICAg Ci0gICAgeyI3MjAiLCAgezUxMiwgMiwgMSwgMiwgMTEyLCAxNDQwLCAweGY5 LCAzLCAgOSwgMiwgQlBCR0FQfX0sCi0gICAgeyIxMjAwIiwgezUxMiwgMSwg MSwgMiwgMjI0LCAyNDAwLCAweGY5LCA3LCAxNSwgMiwgQlBCR0FQfX0sCi0g ICAgeyIxMjMyIiwgezEwMjQsMSwgMSwgMiwgMTkyLCAxMjMyLCAweGZlLCAy LCAgOCwgMiwgQlBCR0FQfX0sICAgIAotICAgIHsiMTQ0MCIsIHs1MTIsIDEs IDEsIDIsIDIyNCwgMjg4MCwgMHhmMCwgOSwgMTgsIDIsIEJQQkdBUH19LAot ICAgIHsiMjg4MCIsIHs1MTIsIDIsIDEsIDIsIDI0MCwgNTc2MCwgMHhmMCwg OSwgMzYsIDIsIEJQQkdBUH19CisgICAgeyIxNjAiLCAgSU5JVCg1MTIsIDEs IDEsIDIsICA2NCwgIDMyMCwgMHhmZSwgMSwgIDgsIDEpfSwKKyAgICB7IjE4 MCIsICBJTklUKDUxMiwgMSwgMSwgMiwgIDY0LCAgMzYwLCAweGZjLCAyLCAg OSwgMSl9LAorICAgIHsiMzIwIiwgIElOSVQoNTEyLCAyLCAxLCAyLCAxMTIs ICA2NDAsIDB4ZmYsIDEsICA4LCAyKX0sCisgICAgeyIzNjAiLCAgSU5JVCg1 MTIsIDIsIDEsIDIsIDExMiwgIDcyMCwgMHhmZCwgMiwgIDksIDIpfSwKKyAg ICB7IjY0MCIsICBJTklUKDUxMiwgMiwgMSwgMiwgMTEyLCAxMjgwLCAweGZi LCAyLCAgOCwgMil9LCAgICAKKyAgICB7IjcyMCIsICBJTklUKDUxMiwgMiwg MSwgMiwgMTEyLCAxNDQwLCAweGY5LCAzLCAgOSwgMil9LAorICAgIHsiMTIw MCIsIElOSVQoNTEyLCAxLCAxLCAyLCAyMjQsIDI0MDAsIDB4ZjksIDcsIDE1 LCAyKX0sCisgICAgeyIxMjMyIiwgSU5JVCgxMDI0LDEsIDEsIDIsIDE5Miwg MTIzMiwgMHhmZSwgMiwgIDgsIDIpfSwgICAgCisgICAgeyIxNDQwIiwgSU5J VCg1MTIsIDEsIDEsIDIsIDIyNCwgMjg4MCwgMHhmMCwgOSwgMTgsIDIpfSwK KyAgICB7IjI4ODAiLCBJTklUKDUxMiwgMiwgMSwgMiwgMjQwLCA1NzYwLCAw eGYwLCA5LCAzNiwgMil9CiB9OwogCiBzdGF0aWMgY29uc3QgdV9pbnQ4X3Qg Ym9vdGNvZGVbXSA9IHsKQEAgLTQyMSw3ICs0MjUsOSBAQAogICAgIH0KICAg ICBpZiAoIXBvd2Vyb2YyKGJwYi5icHMpKQogCWVycngoMSwgImJ5dGVzL3Nl Y3RvciAoJXUpIGlzIG5vdCBhIHBvd2VyIG9mIDIiLCBicGIuYnBzKTsKLSAg ICBpZiAoYnBiLmJwcyA8IE1JTkJQUykKKyAgICBpZiAoYnBiLmJwcyA+IE1B WEJQUykKKyAgICAJcHJpbnRmKCAiV0FSTklORzogYnl0ZXMvc2VjdG9yICgl dSkgaXMgdG9vIGJpZyIsIGJwYi5icHMpOworICAgIGVsc2UgaWYgKGJwYi5i cHMgPCBNSU5CUFMpCiAJZXJyeCgxLCAiYnl0ZXMvc2VjdG9yICgldSkgaXMg dG9vIHNtYWxsOyBtaW5pbXVtIGlzICV1IiwKIAkgICAgIGJwYi5icHMsIE1J TkJQUyk7CiAgICAgaWYgKCEoZmF0ID0gb3B0X0YpKSB7CkBAIC01MzMsNyAr NTM5LDcgQEAKICAgICBpZiAoIWJwYi5yZXMpCiAJYnBiLnJlcyA9IGZhdCA9 PSAzMiA/IE1BWCh4LCBNQVgoMTYzODQgLyBicGIuYnBzLCA0KSkgOiB4Owog ICAgIGVsc2UgaWYgKGJwYi5yZXMgPCB4KQotCWVycngoMSwgInRvbyBmZXcg cmVzZXJ2ZWQgc2VjdG9ycyIpOworCWVycngoMSwgInRvbyBmZXcgcmVzZXJ2 ZWQgc2VjdG9ycyAobmVlZCAlZCBoYXZlICVkKSIsIHgsIGJwYi5yZXMpOwog ICAgIGlmIChmYXQgIT0gMzIgJiYgIWJwYi5yZGUpCiAJYnBiLnJkZSA9IERF RlJERTsKICAgICByZHMgPSBob3dtYW55KGJwYi5yZGUsIGJwYi5icHMgLyBz aXplb2Yoc3RydWN0IGRlKSk7CkBAIC02NTcsOCArNjYzLDggQEAKIAkJCSAo KHVfaW50KXRtLT50bV9ob3VyIDw8IDggfAogCQkJICAodV9pbnQpdG0tPnRt X21pbikpOwogCQltazQoYnN4LT52b2xpZCwgeCk7Ci0JCW1rbGFiZWwoYnN4 LT5sYWJlbCwgb3B0X0wgPyBvcHRfTCA6ICJOTyBOQU1FIik7Ci0JCXNwcmlu dGYoYnVmLCAiRkFUJXUiLCBmYXQpOworCQlta2xhYmVsKGJzeC0+bGFiZWws IG9wdF9MID8gb3B0X0wgOiAiTk9fTkFNRSIpOworCQlzbnByaW50ZihidWYs IHNpemVvZihidWYpLCAiRkFUJXUiLCBmYXQpOwogCQlzZXRzdHIoYnN4LT50 eXBlLCBidWYsIHNpemVvZihic3gtPnR5cGUpKTsKIAkJaWYgKCFvcHRfQikg ewogCQkgICAgeDEgKz0gc2l6ZW9mKHN0cnVjdCBic3gpOwpAQCAtNjY2LDcg KzY3Miw3IEBACiAJCSAgICBtazEoYnMtPmptcFswXSwgMHhlYik7CiAJCSAg ICBtazEoYnMtPmptcFsxXSwgeDEgLSAyKTsKIAkJICAgIG1rMShicy0+am1w WzJdLCAweDkwKTsKLQkJICAgIHNldHN0cihicy0+b2VtLCBvcHRfTyA/IG9w dF9PIDogIkJTRCAgNC40IiwKKwkJICAgIHNldHN0cihicy0+b2VtLCBvcHRf TyA/IG9wdF9PIDogIkJTRDQuNCAgIiwKIAkJCSAgIHNpemVvZihicy0+b2Vt KSk7CiAJCSAgICBtZW1jcHkoaW1nICsgeDEsIGJvb3Rjb2RlLCBzaXplb2Yo Ym9vdGNvZGUpKTsKIAkJICAgIG1rMihpbWcgKyBNSU5CUFMgLSAyLCBET1NN QUdJQyk7Cg== --0-1529515083-1263132417=:73967--