From owner-cvs-src@FreeBSD.ORG Thu Sep 29 15:38:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 45D6F16A41F; Thu, 29 Sep 2005 15:38:06 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4FE543D49; Thu, 29 Sep 2005 15:38:05 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.200] ([10.0.0.200]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j8TFc36j048498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 Sep 2005 08:38:04 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <433C0A4B.8030504@errno.com> Date: Thu, 29 Sep 2005 08:37:47 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050927) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Peter Edwards References: <200509291037.j8TAbKdI010227@repoman.freebsd.org> <20050929130338.GC1715@garage.freebsd.pl> <34cb7c84050929064918862231@mail.gmail.com> In-Reply-To: <34cb7c84050929064918862231@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Edwards , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2005 15:38:06 -0000 Peter Edwards wrote: > On 9/29/05, Pawel Jakub Dawidek wrote: > >>On Thu, Sep 29, 2005 at 10:37:20AM +0000, Peter Edwards wrote: >>+> peadar 2005-09-29 10:37:20 UTC >>+> >>+> FreeBSD src repository >>+> >>+> Modified files: >>+> sys/kern vfs_bio.c >>+> Log: >>+> Close a race in biodone(), whereby the bio_done field of the passed >>+> bio may have been freed and reassigned by the wakeup before being >>+> tested after releasing the bdonelock. >>+> >>+> There's a non-zero chance this is the cause of a few of the crashes >>+> knocking around with biodone() sitting in the stack backtrace. >> >>Should this fix the panic on boot in vmware? >> > > > That one falls under the "non-zero chance" mentioned above :-) The > problem was very intermittent for me, and wanting the laptop not to > fall over seemed to be a prerequisite to reproducing the panic, so I > can't positively say it's fixed the problem yet. > > If you have a reliable way of reproducing the panic, can you try out > the patch and let me know? vmware is great for finding races like these because of the way it handles concurrency. I can remember finding many problems like this in "client operating systems" when I worked on it. Sam