Date: Thu, 8 Oct 2020 18:29:17 +0000 (UTC) From: Mitchell Horne <mhorne@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r366543 - head/sys/kern Message-ID: <202010081829.098ITHNE065741@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mhorne Date: Thu Oct 8 18:29:17 2020 New Revision: 366543 URL: https://svnweb.freebsd.org/changeset/base/366543 Log: Fix a loop condition The correct way to identify the end of the metadata is two adjacent entries set to zero/MODINFO_END. I made a typo and this was checking the first entry twice. Reported by: rpokala Sponsored by: NetApp, Inc. Sponsored by: Klara, Inc. Modified: head/sys/kern/subr_module.c Modified: head/sys/kern/subr_module.c ============================================================================== --- head/sys/kern/subr_module.c Thu Oct 8 18:02:05 2020 (r366542) +++ head/sys/kern/subr_module.c Thu Oct 8 18:29:17 2020 (r366543) @@ -496,7 +496,7 @@ preload_dump_internal(struct sbuf *sbp) */ bptr = (uint32_t *)preload_metadata; sbuf_putc(sbp, '\n'); - while (bptr[0] != MODINFO_END || bptr[0] != MODINFO_END) { + while (bptr[0] != MODINFO_END || bptr[1] != MODINFO_END) { sbuf_printf(sbp, " %p:\n", bptr); type = *bptr++; len = *bptr++;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202010081829.098ITHNE065741>