From owner-p4-projects@FreeBSD.ORG Fri Feb 2 00:38:15 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 2D23A16A405; Fri, 2 Feb 2007 00:38:15 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BF74216A402 for ; Fri, 2 Feb 2007 00:38:14 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.freebsd.org (Postfix) with ESMTP id 81FBF13C494 for ; Fri, 2 Feb 2007 00:38:14 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.6/8.13.6) with ESMTP id l120c8W1012027; Thu, 1 Feb 2007 19:38:13 -0500 (EST) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Divacky Roman Date: Thu, 1 Feb 2007 19:37:50 -0500 User-Agent: KMail/1.6.2 References: <200701310016.l0V0GccJ095661@repoman.freebsd.org> <20070131085906.GA28186@stud.fit.vutbr.cz> <200701311218.51103.jkim@FreeBSD.org> In-Reply-To: <200701311218.51103.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200702011938.05616.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.88.6/2514/Thu Feb 1 16:50:10 2007 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: Perforce Change Reviews Subject: Re: PERFORCE change 113739 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2007 00:38:15 -0000 On Wednesday 31 January 2007 12:18 pm, Jung-uk Kim wrote: > On Wednesday 31 January 2007 03:59 am, Divacky Roman wrote: > > On Wed, Jan 31, 2007 at 12:16:38AM +0000, Jung-uk Kim wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=113739 > > > > > > Change 113739 by jkim@jkim_hammer on 2007/01/31 00:15:36 > > > > > > Do not reload %gs from linux_*sigcode(). > > > This seem to fix TLS on amd64, finally. :-) > > > > > > Tested on UP and QEMU. Need more testing on SMP. > > > > > > Affected files ... > > > > > > .. > > > //depot/projects/linuxolator/src/sys/amd64/linux32/linux32_loco > > >re .s#2 edit > > > > > > Differences ... > > > > > > ==== > > > //depot/projects/linuxolator/src/sys/amd64/linux32/linux32_loco > > >re .s#2 (text+ko) ==== > > > > > > @@ -11,7 +11,9 @@ > > > NON_GPROF_ENTRY(linux_sigcode) > > > call *LINUX_SIGF_HANDLER(%esp) > > > leal LINUX_SIGF_SC(%esp),%ebx /* linux scp */ > > > +#if 0 > > > movl LINUX_SC_GS(%ebx),%gs > > > +#endif > > > movl LINUX_SC_FS(%ebx),%fs > > > movl LINUX_SC_ES(%ebx),%es > > > movl LINUX_SC_DS(%ebx),%ds > > > @@ -25,7 +27,9 @@ > > > linux_rt_sigcode: > > > call *LINUX_RT_SIGF_HANDLER(%esp) > > > leal LINUX_RT_SIGF_UC(%esp),%ebx /* linux ucp */ > > > +#if 0 > > > movl LINUX_SC_GS(%ebx),%gs > > > +#endif > > > > great work! why didnt you just remove those lines but if 0 them? > > Because it's not done yet. I need more testing and clean-up before > MFP4. I'd like to test it on SMP but I don't have one. :-( I tried this on QEMU with dual-CPU emulation but it didn't look good. :-( We will have to find correct way to fix this. Jung-uk Kim