From owner-freebsd-bugs@FreeBSD.ORG  Tue Oct 25 12:30:14 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6396916A420
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 25 Oct 2005 12:30:14 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CFEBA43D4C
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 25 Oct 2005 12:30:13 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9PCUDaR083907
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 25 Oct 2005 12:30:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9PCUDLm083906;
	Tue, 25 Oct 2005 12:30:13 GMT (envelope-from gnats)
Resent-Date: Tue, 25 Oct 2005 12:30:13 GMT
Resent-Message-Id: <200510251230.j9PCUDLm083906@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Sergey Svishchev <svs+pr@grep.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DE55E16A41F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 25 Oct 2005 12:24:44 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A4AD843D4C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 25 Oct 2005 12:24:44 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j9PCOimJ062014
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Oct 2005 12:24:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j9PCOhDT062013;
	Tue, 25 Oct 2005 12:24:43 GMT (envelope-from nobody)
Message-Id: <200510251224.j9PCOhDT062013@www.freebsd.org>
Date: Tue, 25 Oct 2005 12:24:43 GMT
From: Sergey Svishchev <svs+pr@grep.ru>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: bin/87981: ipmon writes pid file even when not in daemon mode
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2005 12:30:14 -0000


>Number:         87981
>Category:       bin
>Synopsis:       ipmon writes pid file even when not in daemon mode
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 25 12:30:13 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Sergey Svishchev
>Release:        5.2.1
>Organization:
>Environment:
>Description:
ipmon is supposed to write its PID to /var/run/ipmon.pid only when it is running as daemon; however, it does that even if -D is not specified.

Consequently, if newsyslog is configured to rotate ipmon's log file and notify ipmon afterwards, it is unable to do so, since pid file contains wrong PID.
>How-To-Repeat:

>Fix:
--- ipmon.c.orig	2005-07-25 14:34:05.379137800 +0400
+++ ipmon.c	2005-07-25 14:23:16.000000000 +0400
@@ -1417,8 +1417,8 @@
 #endif /* !BSD */
 		close(0);
 		close(1);
+		write_pid(pidfile);
 	}
-	write_pid(pidfile);
 
 	signal(SIGHUP, handlehup);
 

>Release-Note:
>Audit-Trail:
>Unformatted: