From owner-svn-src-head@freebsd.org Wed Oct 31 14:12:19 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB5D610DAB97; Wed, 31 Oct 2018 14:12:18 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49B6E76DF3; Wed, 31 Oct 2018 14:12:18 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lf1-x129.google.com with SMTP id h192so11765728lfg.3; Wed, 31 Oct 2018 07:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=usWPUN25vv2Db7zMbidg6FWEJkqndvVQCp3L1VYJAEI=; b=VYIRLwDMTnckKlgvrS2SZ6KOF8H4dk0fVR5nz1TPktBWShUJQuHcSg3cslajrQ+7ri VAjvGZi9L+Cbc4AebqJV//TetH6UKUKBoT4k8IInqX54o/nsdfOEa99sfAY4c/S60BPh n+gFWvByeIeCpvhuUE+RzSXnN4gfe4/IulSYa3VwIUWHO2FY9rZSoCioToFjiE2OkK41 AfDEQIxBBNlqwnwyYmqbuyMeGl2SMPjJq9KjbK+gDVU/dIZq+Wp23I8H1/bAJGg3nRyx ALORobty6RQonN5wn5iCCdEeE3+bQtXBmja1Y9s1V4rm43aeD1lXXCss9gmnl1/iyitq KNkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=usWPUN25vv2Db7zMbidg6FWEJkqndvVQCp3L1VYJAEI=; b=dF0qlNKN3kEdyPc8vDE6XkyzkKUYBiHRhtCX/3T/b6GsVd2ys8/dr1+fq4kC0MdcY/ E6jqFuZiPqtik7UgmQZzNB/lKHXD6hTb2GrFxk2xm780LfFGpyew5gjjcRdGMcfRBxMs GYA+4wSUlqXgIugXS6COoxvq5KjV/sXjVDZCeYTKPsfGvdHShC/z7vGuoz/2Ahh+Ub8O l6Iv82MLnAUIjuuRCK/Oyae3y+r7Vjg2mq/CV1Jb9+Ro44ER/2sj6n/D8wsTYCqS7flz coq0g2Z3YFXDgJJrGEc3xfkTSfquvLUDVsGsPUlbk0ZhFBB6Z5pzd4X3BAHC7IYWtH/E HXrg== X-Gm-Message-State: AGRZ1gJQI/LDzIHLMkoj6p3HY4MD26AOIbza1TBriPYQXv78f1DSEzGP XkFcca2N6QomWz1VK863v7PS1ak52I98nmeazd89AQ== X-Google-Smtp-Source: AJdET5dYDyjH3SQPEAbmkZTU8GHQcH4M+X+8gnGWcrSKhYMSpnbmbDK19n5R4Zx1QvWYXhRT6ErQFwkGEK/vV4kiZjI= X-Received: by 2002:a19:1d0d:: with SMTP id d13mr1906787lfd.74.1540995136081; Wed, 31 Oct 2018 07:12:16 -0700 (PDT) MIME-Version: 1.0 References: <201810310127.w9V1RiFX025463@repo.freebsd.org> <20181031140631.ipwlwh3rlm7ma4xk@mutt-hbsd> In-Reply-To: <20181031140631.ipwlwh3rlm7ma4xk@mutt-hbsd> Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Wed, 31 Oct 2018 22:12:04 +0800 Message-ID: Subject: Re: svn commit: r339936 - head/sys/amd64/vmm/amd To: Shawn Webb Cc: Marcelo Araujo , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 14:12:19 -0000 On Wed, Oct 31, 2018, 10:07 PM Shawn Webb wrote: > On Wed, Oct 31, 2018 at 01:27:44AM +0000, Marcelo Araujo wrote: > > Author: araujo > > Date: Wed Oct 31 01:27:44 2018 > > New Revision: 339936 > > URL: https://svnweb.freebsd.org/changeset/base/339936 > > > > Log: > > Merge cases with upper block. > > This is a cosmetic change only to simplify code. > > > > Reported by: anish > > Sponsored by: iXsystems Inc. > > > > Modified: > > head/sys/amd64/vmm/amd/svm_msr.c > > > > Modified: head/sys/amd64/vmm/amd/svm_msr.c > > > ============================================================================== > > --- head/sys/amd64/vmm/amd/svm_msr.c Tue Oct 30 23:09:04 2018 > (r339935) > > +++ head/sys/amd64/vmm/amd/svm_msr.c Wed Oct 31 01:27:44 2018 > (r339936) > > @@ -122,11 +122,7 @@ svm_rdmsr(struct svm_softc *sc, int vcpu, u_int > num, u > > case MSR_MTRR16kBase ... MSR_MTRR16kBase + 1: > > case MSR_MTRR64kBase: > > case MSR_SYSCFG: > > - *result = 0; > > - break; > > case MSR_AMDK8_IPM: > > - *result = 0; > > - break; > > case MSR_EXTFEATURES: > > *result = 0; > > break; > > Does this need a /* FALLTHROUGH */ comment to appease the Coverity > Gods? > Wow yeah, probably yes!!! I will check tomorrow! Thanks. > Thanks, > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > Tor-ified Signal: +1 443-546-8752 > Tor+XMPP+OTR: lattera@is.a.hacker.sx > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE >