Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Oct 2017 03:39:54 +0000 (UTC)
From:      Cy Schubert <cy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r324248 - head
Message-ID:  <201710040339.v943dskR001109@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cy
Date: Wed Oct  4 03:39:54 2017
New Revision: 324248
URL: https://svnweb.freebsd.org/changeset/base/324248

Log:
  When building multiple kernels using KERNCONF, non-existent KERNCONF
  files will produce an error and buildkernel will fail. Previously missing
  KERNCONF files silently failed giving no indication as to why, only to
  subsequently discover during installkernel that the desired kernel was
  never built in the first place.
  
  This is a rework of r302865.
  
  This is the correct patch.
  
  Reviewed by:	ngie (previous version, r302865)
  MFC after:	2 months
  Differential Revision:	D7167

Modified:
  head/Makefile.inc1
  head/UPDATING

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1	Wed Oct  4 03:35:23 2017	(r324247)
+++ head/Makefile.inc1	Wed Oct  4 03:39:54 2017	(r324248)
@@ -1359,6 +1359,10 @@ BUILDKERNELS+=	${_kernel}
 .if empty(INSTALLKERNEL) && !defined(NO_INSTALLKERNEL)
 INSTALLKERNEL= ${_kernel}
 .endif
+.else
+.if make(buildkernel)
+.error Missing KERNCONF ${KERNCONFDIR}/${_kernel}
+.endif
 .endif
 .endfor
 

Modified: head/UPDATING
==============================================================================
--- head/UPDATING	Wed Oct  4 03:35:23 2017	(r324247)
+++ head/UPDATING	Wed Oct  4 03:39:54 2017	(r324248)
@@ -51,6 +51,13 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLOW:
 
 ****************************** SPECIAL WARNING: ******************************
 
++20160714:
+	When building multiple kernels using KERNCONF, non-existent KERNCONF
+	files will produce an error and buildkernel will fail. Previously
+	missing KERNCONF files silently failed giving no indication as to
+	why, only to subsequently discover during installkernel that the
+	desired kernel was never built in the first place.
+
 20170912:
 	The default serial number format for CTL LUNs has changed.  This will
 	affect users who use /dev/diskid/* device nodes, or whose FibreChannel



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710040339.v943dskR001109>