From owner-svn-src-head@freebsd.org Wed Feb 15 21:45:14 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 93709CDF598 for ; Wed, 15 Feb 2017 21:45:14 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-75.reflexion.net [208.70.210.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3CC56CD6 for ; Wed, 15 Feb 2017 21:45:13 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 24561 invoked from network); 15 Feb 2017 21:47:13 -0000 Received: from unknown (HELO mail-cs-02.app.dca.reflexion.local) (10.81.19.2) by 0 (rfx-qmail) with SMTP; 15 Feb 2017 21:47:13 -0000 Received: by mail-cs-02.app.dca.reflexion.local (Reflexion email security v8.30.0) with SMTP; Wed, 15 Feb 2017 16:45:12 -0500 (EST) Received: (qmail 4117 invoked from network); 15 Feb 2017 21:45:11 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 15 Feb 2017 21:45:11 -0000 Received: from [192.168.1.111] (c-67-170-167-181.hsd1.or.comcast.net [67.170.167.181]) by iron2.pdx.net (Postfix) with ESMTPSA id 246CEEC788F; Wed, 15 Feb 2017 13:45:11 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: svn commit: r313772 - head/sys/arm64/arm64 From: Mark Millard In-Reply-To: Date: Wed, 15 Feb 2017 13:45:10 -0800 Cc: Andrew Turner , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <22EF24E0-3DEA-44C4-AE23-2290082CB574@dsl-only.net> References: <62A5F129-EFD3-496B-854C-9D8623EFFD38@dsl-only.net> To: Oliver Pinter X-Mailer: Apple Mail (2.3259) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 21:45:14 -0000 On 2017-Feb-15, at 1:39 PM, Oliver Pinter = wrote: > On 2/15/17, Mark Millard wrote: >>> Author: andrew >>> Date: Wed Feb 15 14:56:47 2017 >>> New Revision: 313772 >>> URL: >>> https://svnweb.freebsd.org/changeset/base/313772 >>>=20 >>> Log: >>> Load the new sp_el0 with interrupts disabled in fork_trampoline. If = an >>> interrupt arrives in fork_trampoline after sp_el0 was written we = may >>> then >>> switch to a new thread, enter userland so change this stack = pointer, >>> then >>> return to this code with the wrong value. This fixes this case by >>> moving >>> the load of sp_el0 until after interrupts have been disabled. >>=20 >> = https://svnweb.freebsd.org/base/stable/11/sys/arm64/arm64/swtch.S?revision= =3D302408&view=3Dmarkup >>=20 >> shows stable/11 has the same issue. >>=20 >> Is this to be MFC'd at some point? >>=20 >>=20 >> stable/10 seems to have a different code structure: >>=20 >> https://svnweb.freebsd.org/base/stable/10/sys/amd64/amd64/ >=20 > This is x86-64 aka amd64 in FreeBSD, in 10-STABLE only 32 bit ARM > support exists, so there isn't arm64. Clearly I was somewhat distracted and careless when I looked at stable/10. Sorry for the noise in that part. Still the stable/11 part does apply: at least I got something right. >>=20 >> . . . =3D=3D=3D Mark Millard markmi at dsl-only.net