From owner-svn-src-head@FreeBSD.ORG Sun Nov 8 15:20:10 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8044106566B; Sun, 8 Nov 2009 15:20:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id 2ED8E8FC18; Sun, 8 Nov 2009 15:20:09 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id nA8FK6w1001393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 8 Nov 2009 17:20:06 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id nA8FK6x4000181; Sun, 8 Nov 2009 17:20:06 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id nA8FK6hJ000180; Sun, 8 Nov 2009 17:20:06 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 8 Nov 2009 17:20:06 +0200 From: Kostik Belousov To: Alexander Motin Message-ID: <20091108152006.GS2331@deviant.kiev.zoral.com.ua> References: <200911081433.nA8EXJnp088767@svn.freebsd.org> <20091108143633.GR2331@deviant.kiev.zoral.com.ua> <4AF6D85B.4040905@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="B9I4cJCE9PLEoxgz" Content-Disposition: inline In-Reply-To: <4AF6D85B.4040905@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r199050 - in head/sys: conf dev/ata X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Nov 2009 15:20:10 -0000 --B9I4cJCE9PLEoxgz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 08, 2009 at 04:40:27PM +0200, Alexander Motin wrote: > Kostik Belousov wrote: > > On Sun, Nov 08, 2009 at 02:33:19PM +0000, Alexander Motin wrote: > >> Author: mav > >> Date: Sun Nov 8 14:33:19 2009 > >> New Revision: 199050 > >> URL: http://svn.freebsd.org/changeset/base/199050 > >> > >> Log: > >> Introduce define and kernel option ATA_REQUEST_TIMEOUT to control AT= A(4) > >> command timeout. > >=20 > > Why is this a compile-time option ? Having to recompile kernel for this > > is too much, IMHO. It should be loader tunable + sysctl, isn't it. >=20 > As I have told once, I think it is not a thing that should be often > tuned by end-user, especially in real-time. I just turned it into macro, Absolutely. I agree with that most users never need this tunable. > as some people complain about using numerous equal numeric constants. But, why not be somewhat more friendly to a user that already has a problam, and force him to recompile the kernel only to check whether it helps or not ? --B9I4cJCE9PLEoxgz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkr24aYACgkQC3+MBN1Mb4gMvwCeNjHRt94gy9wvCQTrLeyecrCi ueQAn212MIZ6f44YXQ0gmZwZZatLe3NI =M6r1 -----END PGP SIGNATURE----- --B9I4cJCE9PLEoxgz--