From owner-freebsd-current@FreeBSD.ORG Mon Jun 1 16:35:03 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F8A61065676 for ; Mon, 1 Jun 2009 16:35:03 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id B41A68FC18 for ; Mon, 1 Jun 2009 16:35:02 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 9922 invoked by uid 399); 1 Jun 2009 16:34:58 -0000 Received: from localhost (HELO ?192.168.0.101?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 1 Jun 2009 16:34:58 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A240331.1000803@FreeBSD.org> Date: Mon, 01 Jun 2009 09:34:57 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Andriy Gapon References: <4A23D5A4.6020009@icyb.net.ua> <4A23F4B8.7000002@freebsd.org> In-Reply-To: <4A23F4B8.7000002@freebsd.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: freebsd-current@freebsd.org Subject: Re: fsck_y_enable: use -C X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2009 16:35:03 -0000 Andriy Gapon wrote: > on 01/06/2009 16:20 Andriy Gapon said the following: >> What about the following patch? >> I believe that the idea behind fsck_y_enable is to try to make unattended systems >> with rw filesystems as recoverable as possible at the cost of potential damage to >> the data. The new "-C" option should not interfere with this goal, but should >> reduce recovery time, because currently fsck -y checks *all* filesystems from >> fstab, even those that are ro or clean: >> >> -C Check if the “clean” flag is set in the superblock and skip file >> system checks if file system was properly dismounted and marked >> clean. >> > > One potential issue that I've just thought of is that fsck_msdosfs doesn't seem to > support this option (even in a dummy way), so it would be a problem for those who > have msdos filesystems in fstab and also have fsck_y_enable. I'm a bit concerned that we keep the current option as it is, but I would support adding an fsck_y_enable_flags option to allow people to pass -C if they are sure it will work in their environment. Doug