From owner-freebsd-bugs  Mon May 21  2:30:16 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 9C14537B43E
	for <freebsd-bugs@hub.freebsd.org>; Mon, 21 May 2001 02:30:12 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4L9UCj77757;
	Mon, 21 May 2001 02:30:12 -0700 (PDT)
	(envelope-from gnats)
Received: from ns.any.ru (ns.any.ru [194.67.127.11])
	by hub.freebsd.org (Postfix) with ESMTP id 9307037B424
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 May 2001 02:24:01 -0700 (PDT)
	(envelope-from avn@ns.any.ru)
Received: (from avn@localhost)
	by ns.any.ru (8.11.3/8.11.3) id f4L9M2N39761
	for FreeBSD-gnats-submit@freebsd.org.AVP; Mon, 21 May 2001 13:22:02 +0400 (MSD)
	(envelope-from avn)
Received: (from avn@localhost)
	by ns.any.ru (8.11.3/8.11.3) id f4L9M2S39752;
	Mon, 21 May 2001 13:22:02 +0400 (MSD)
	(envelope-from avn)
Message-Id: <200105210922.f4L9M2S39752@ns.any.ru>
Date: Mon, 21 May 2001 13:22:02 +0400 (MSD)
From: avn@any.ru
Reply-To: avn@any.ru
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: misc/27492: syslog.h fails to compile with -Wwrite-strings
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         27492
>Category:       misc
>Synopsis:       syslog.h fails to compile with -Wwrite-strings
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 21 02:30:02 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Alexey V. Neyman
>Release:        FreeBSD 4.3-STABLE
>Organization:
ANY.RU
>Environment:
FreeBSD srv2.any 4.3-STABLE FreeBSD 4.3-STABLE #2: Thu May 17 19:01:42 MSD 2001
    toor@srv2.any:/usr2/obj/usr2/src/sys/SRV2  i386
>Description:
>How-To-Repeat:
$cat > a.c
#define SYSLOG_NAMES
#include <stdio.h>
#include <syslog.h>
int main(void) {return 0;}
^D
$gcc -Wwrite-strings -Werror a.c
In file included from a.c:3:
/usr/include/syslog.h:76: warning: initialization discards qualifiers from point
er target type
[ ... many more warnings skipped ... ]
>Fix:

--- syslog.h.orig	Mon May 21 13:04:27 2001
+++ syslog.h	Mon May 21 13:05:19 2001
@@ -68,8 +68,8 @@
 				/* mark "facility" */
 #define	INTERNAL_MARK	LOG_MAKEPRI((LOG_NFACILITIES<<3), 0)
 typedef struct _code {
-	char	*c_name;
-	int	c_val;
+	const char	*c_name;
+	int		c_val;
 } CODE;
 
 CODE prioritynames[] = {
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message