From owner-freebsd-bugs  Fri Mar 29  1:30:33 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 5500637B41C
	for <freebsd-bugs@hub.freebsd.org>; Fri, 29 Mar 2002 01:30:03 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g2T9U3061523;
	Fri, 29 Mar 2002 01:30:03 -0800 (PST)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 6D82437B41B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 29 Mar 2002 01:25:28 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g2T9PSu60783;
	Fri, 29 Mar 2002 01:25:28 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200203290925.g2T9PSu60783@freefall.freebsd.org>
Date: Fri, 29 Mar 2002 01:25:28 -0800 (PST)
From: Joshua Goodall <joshua@roughtrade.net>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: bin/36473: Overdue MFC's in chmod/chown/chflags
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         36473
>Category:       bin
>Synopsis:       Overdue MFC's in chmod/chown/chflags
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 29 01:30:03 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Joshua Goodall
>Release:        4-stable
>Organization:
>Environment:
FreeBSD green.shallow.net 4.5-STABLE FreeBSD 4.5-STABLE #0: Fri Feb  1 00:19:52 EST 2002 joshua@green.shallow.net:/usr/obj/usr/src/sys/GREEN  i386

>Description:
The following are now very overdue MFC's:

r1.17 and r1.18 of src/usr.sbin/chown/chown.c
- Follow symbolic links named as command line arguments without -R.
- chown -h owner symlink did not set the symlink's owner
  if the file the symlink points to already had that owner

r1.20 r1.21 and r1.22 of src/bin/chmod/chmod.c
- Follow symbolic links named as command line arguments without -R
- Change noop option -h to do the real work.
- chmod -h mode symlink did not set the symlink's mode
  if the file the symlink points to already had that mode

r1.11 of src/usr.bin/chflags/chflags.c
- Follow symbolic links named as command line arguments without -R


>How-To-Repeat:
      
>Fix:
Attention to these permission-related details would be appreciated!
Please arrange MFC.

Note that there is no lchflags syscall, so changing symlink
flags is not an issue (subject of an existing open PR).

Joshua

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message