From owner-cvs-all@FreeBSD.ORG  Mon Dec  6 15:49:52 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D499C16A4CE; Mon,  6 Dec 2004 15:49:52 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C424F43D2D; Mon,  6 Dec 2004 15:49:52 +0000 (GMT)
	(envelope-from delphij@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iB6FnqLQ086864;
	Mon, 6 Dec 2004 15:49:52 GMT
	(envelope-from delphij@repoman.freebsd.org)
Received: (from delphij@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iB6FnqhN086863;
	Mon, 6 Dec 2004 15:49:52 GMT
	(envelope-from delphij)
Message-Id: <200412061549.iB6FnqhN086863@repoman.freebsd.org>
From: Xin LI <delphij@FreeBSD.org>
Date: Mon, 6 Dec 2004 15:49:52 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/usr.sbin/pppd cbcp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Dec 2004 15:49:53 -0000

delphij     2004-12-06 15:49:52 UTC

  FreeBSD src repository

  Modified files:
    usr.sbin/pppd        cbcp.c 
  Log:
  Correct two bugs that may result in incorrect CBCP response for
  administrator specified number.
  
  The implementation in our version transmits extra zero byte that is a
  violation of the Microsoft PPP Callback Control Protocol section 3.2[1].
  This can lead to incorrect behavior on certain devices, as reported
  in bin/50613.
  
  Confirmed with: cbcp.c in ppp's cvs, rev. 1.4 and 1.15 [2]
  
  Submitted by:   Dmitry Pryanishnikov <dmitry at atlantis.dp.ua>
  PR:             bin/50613
  
  [1] http://www.dsl.gr.jp/~manabe/PPxP/doc/Standards/draft-gidwani-ppp-callback-cp-00.txt
  [2] http://cvs.samba.org/cgi-bin/cvsweb/ppp/pppd/cbcp.c
      http://www.samba.org/cvs.html
  
  Revision  Changes    Path
  1.7       +3 -5      src/usr.sbin/pppd/cbcp.c