From owner-svn-src-head@freebsd.org  Tue Sep 22 10:02:32 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F194A05333;
 Tue, 22 Sep 2015 10:02:32 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BA2D717AC;
 Tue, 22 Sep 2015 10:02:31 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from slw by zxy.spb.ru with local (Exim 4.84 (FreeBSD))
 (envelope-from <slw@zxy.spb.ru>)
 id 1ZeKP7-000Bxk-IS; Tue, 22 Sep 2015 13:02:29 +0300
Date: Tue, 22 Sep 2015 13:02:29 +0300
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Dimitry Andric <dim@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r288099 - head/contrib/binutils/opcodes
Message-ID: <20150922100229.GN21849@zxy.spb.ru>
References: <201509220935.t8M9ZZfD051027@repo.freebsd.org>
 <20150922094301.GW3158@zxy.spb.ru>
 <4CD0DC75-0235-4890-827C-4FF41BBADD8A@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CD0DC75-0235-4890-827C-4FF41BBADD8A@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 10:02:32 -0000

On Tue, Sep 22, 2015 at 11:53:32AM +0200, Dimitry Andric wrote:

> On 22 Sep 2015, at 11:43, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote:
> > 
> > On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote:
> ...
> >> -			  imm |= (-1 << 7);
> >> +			  imm |= -(1 << 7);
> > 
> > May be (~0 << 7) is more simple to understund?
> 
> This will give the same warning.  ~0 will implicitly convert to -1.

(~0U << 7) ?

> (It would be better to convert all these masks to unsigned, where such
> shifting is always defined, but that gives a lot more churn.)
> 
> -Dimitry
>