From owner-freebsd-ports@FreeBSD.ORG Sat May 17 09:39:21 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1D3637B401 for ; Sat, 17 May 2003 09:39:21 -0700 (PDT) Received: from mta02-svc.ntlworld.com (mta02-svc.ntlworld.com [62.253.162.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1C2E43F85 for ; Sat, 17 May 2003 09:39:20 -0700 (PDT) (envelope-from jon@witchspace.com) Received: from witchspace.com ([80.3.251.242]) by mta02-svc.ntlworld.com (InterMail vM.4.01.03.37 201-229-121-137-20020806) with SMTP id <20030517163919.YKCG9882.mta02-svc.ntlworld.com@witchspace.com> for ; Sat, 17 May 2003 17:39:19 +0100 Received: (qmail 87527 invoked from network); 17 May 2003 16:39:19 -0000 Received: from unknown (HELO witchspace.com) (192.168.0.1) by dookie.witchspace.com with SMTP; 17 May 2003 16:39:19 -0000 Message-ID: <3EC665B6.5040102@witchspace.com> Date: Sat, 17 May 2003 17:39:18 +0100 From: Jonathan Belson User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030509 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Erik Trulsson References: <3EC53C6C.1040904@witchspace.com> <20030517121908.GA67369@rot13.obsecurity.org> <3EC62CC2.6090209@witchspace.com> <20030517130549.GA44928@falcon.midgard.homeip.net> <3EC63B78.6010203@witchspace.com> <20030517135217.GA88537@falcon.midgard.homeip.net> <3EC6439F.5020700@witchspace.com> <20030517155457.GA94423@falcon.midgard.homeip.net> In-Reply-To: <20030517155457.GA94423@falcon.midgard.homeip.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: ports@FreeBSD.org Subject: Re: FreeBSD Port: pornview-0.2.0.p.1 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 May 2003 16:39:22 -0000 rik Trulsson wrote: > With that definition of stdin/stdout/stderr the code in pornview > happens to work. I suspect that code wasn't tested on anything except > Linux. Not uncommon, unfortunately. > A bit of Googling leads me to believe that they were required to be > macros in C89 as well, even though many implementations didn't define > them that way. > Unfortunately I don't have a copy of the original ANSI C standard so I > can't check what it says there. I couldn't see any reference to stdin/stdout/stderr other than the one I quoted you. > I don't think "lovely" is a word I will ever use to describe anything > involving #undef. "Ugly" is the word that comes to mind when thinking > about any situation that would require the use of #undef. Um, I was being sarcastic. >>I'll contact the author and explain the situation, someone else can >>look at/commit the patch you posted. Done. --Jon http://www.witchspace.com